Skip to content

Commit ce62f96

Browse files
authored
Merge branch 'master' into bump/python_3.9+
2 parents 5da2e43 + cae3335 commit ce62f96

File tree

8 files changed

+83
-36
lines changed

8 files changed

+83
-36
lines changed

.github/checkgroup.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ subprojects:
1919
- "!*.md"
2020
- "!**/*.md"
2121
checks:
22-
- "pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest)"
22+
- "pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest)"
2323
- "pl-cpu (macOS-14, lightning, 3.10, 2.1)"
2424
- "pl-cpu (macOS-14, lightning, 3.11, 2.2.2)"
2525
- "pl-cpu (macOS-14, lightning, 3.11, 2.3)"
@@ -171,7 +171,7 @@ subprojects:
171171
- "!*.md"
172172
- "!**/*.md"
173173
checks:
174-
- "fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest)"
174+
- "fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest)"
175175
- "fabric-cpu (macOS-14, lightning, 3.10, 2.1)"
176176
- "fabric-cpu (macOS-14, lightning, 3.11, 2.2.2)"
177177
- "fabric-cpu (macOS-14, lightning, 3.11, 2.3)"
@@ -266,14 +266,14 @@ subprojects:
266266
- "install-pkg (ubuntu-22.04, lightning, 3.11)"
267267
- "install-pkg (ubuntu-22.04, notset, 3.9)"
268268
- "install-pkg (ubuntu-22.04, notset, 3.11)"
269-
- "install-pkg (macOS-13, fabric, 3.9)"
270-
- "install-pkg (macOS-13, fabric, 3.11)"
271-
- "install-pkg (macOS-13, pytorch, 3.9)"
272-
- "install-pkg (macOS-13, pytorch, 3.11)"
273-
- "install-pkg (macOS-13, lightning, 3.9)"
274-
- "install-pkg (macOS-13, lightning, 3.11)"
275-
- "install-pkg (macOS-13, notset, 3.9)"
276-
- "install-pkg (macOS-13, notset, 3.11)"
269+
- "install-pkg (macOS-14, fabric, 3.9)"
270+
- "install-pkg (macOS-14, fabric, 3.11)"
271+
- "install-pkg (macOS-14, pytorch, 3.9)"
272+
- "install-pkg (macOS-14, pytorch, 3.11)"
273+
- "install-pkg (macOS-14, lightning, 3.9)"
274+
- "install-pkg (macOS-14, lightning, 3.11)"
275+
- "install-pkg (macOS-14, notset, 3.9)"
276+
- "install-pkg (macOS-14, notset, 3.11)"
277277
- "install-pkg (windows-2022, fabric, 3.9)"
278278
- "install-pkg (windows-2022, fabric, 3.11)"
279279
- "install-pkg (windows-2022, pytorch, 3.9)"

.github/workflows/ci-pkg-install.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
strategy:
4343
fail-fast: false
4444
matrix:
45-
os: ["ubuntu-22.04", "macOS-13", "windows-2022"]
45+
os: ["ubuntu-22.04", "macOS-14", "windows-2022"]
4646
pkg-name: ["fabric", "pytorch", "lightning", "notset"]
4747
python-version: ["3.9", "3.11"]
4848
steps:

.github/workflows/ci-tests-fabric.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
- { os: "ubuntu-22.04", pkg-name: "fabric", python-version: "3.12", pytorch-version: "2.5.1" }
6161
- { os: "windows-2022", pkg-name: "fabric", python-version: "3.12", pytorch-version: "2.5.1" }
6262
# "oldest" versions tests, only on minimum Python
63-
- { os: "macOS-13", pkg-name: "lightning", python-version: "3.9", pytorch-version: "2.1", requires: "oldest" }
63+
- { os: "macOS-14", pkg-name: "lightning", python-version: "3.9", pytorch-version: "2.1", requires: "oldest" }
6464
- {
6565
os: "ubuntu-20.04",
6666
pkg-name: "lightning",
@@ -101,7 +101,10 @@ jobs:
101101

102102
- name: Set min. dependencies
103103
if: ${{ matrix.requires == 'oldest' }}
104-
run: python .actions/assistant.py replace_oldest_ver
104+
run: |
105+
python .actions/assistant.py replace_oldest_ver
106+
pip install "cython<3.0" wheel
107+
pip install "pyyaml==5.4" --no-build-isolation
105108
106109
- name: Adjust PyTorch versions in requirements files
107110
if: ${{ matrix.requires != 'oldest' }}

.github/workflows/ci-tests-pytorch.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
- { os: "ubuntu-22.04", pkg-name: "pytorch", python-version: "3.12", pytorch-version: "2.5.1" }
6565
- { os: "windows-2022", pkg-name: "pytorch", python-version: "3.12", pytorch-version: "2.5.1" }
6666
# "oldest" versions tests, only on minimum Python
67-
- { os: "macOS-13", pkg-name: "lightning", python-version: "3.9", pytorch-version: "2.1", requires: "oldest" }
67+
- { os: "macOS-14", pkg-name: "lightning", python-version: "3.9", pytorch-version: "2.1", requires: "oldest" }
6868
- {
6969
os: "ubuntu-20.04",
7070
pkg-name: "lightning",
@@ -106,7 +106,10 @@ jobs:
106106

107107
- name: Set min. dependencies
108108
if: ${{ matrix.requires == 'oldest' }}
109-
run: python .actions/assistant.py replace_oldest_ver
109+
run: |
110+
python .actions/assistant.py replace_oldest_ver
111+
pip install "cython<3.0" wheel
112+
pip install "pyyaml==5.4" --no-build-isolation
110113
111114
- name: Adjust PyTorch versions in requirements files
112115
if: ${{ matrix.requires != 'oldest' }}

src/lightning/pytorch/loggers/mlflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ def save_dir(self) -> Optional[str]:
300300
301301
"""
302302
if self._tracking_uri.startswith(LOCAL_FILE_URI_PREFIX):
303-
return self._tracking_uri.lstrip(LOCAL_FILE_URI_PREFIX)
303+
return self._tracking_uri[len(LOCAL_FILE_URI_PREFIX) :]
304304
return None
305305

306306
@property

src/lightning/pytorch/utilities/data.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,8 @@ def _is_dataloader_shuffled(dataloader: object) -> bool:
350350
if not hasattr(dataloader, "sampler"):
351351
# shuffling is enabled via a sampler. No sampler, no shuffling
352352
return False
353-
sampler = dataloader.sampler
353+
batch_sampler = dataloader.batch_sampler
354+
sampler = batch_sampler.sampler if batch_sampler is not None else dataloader.sampler
354355
if isinstance(sampler, SequentialSampler):
355356
return False
356357
return isinstance(sampler, RandomSampler)

tests/tests_pytorch/test_cli.py

Lines changed: 32 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -878,18 +878,27 @@ def test_lightning_cli_load_from_checkpoint_dependency_injection(cleandir):
878878
hparams_path = Path(cli.trainer.log_dir) / "hparams.yaml"
879879
assert hparams_path.is_file()
880880
hparams = yaml.safe_load(hparams_path.read_text())
881-
expected = {
882-
"_instantiator": "lightning.pytorch.cli.instantiate_module",
883-
"optimizer": "torch.optim.Adam",
884-
"scheduler": "torch.optim.lr_scheduler.ConstantLR",
885-
"activation": {"class_path": "torch.nn.LeakyReLU", "init_args": {"negative_slope": 0.05, "inplace": False}},
886-
}
887-
assert hparams == expected
881+
882+
expected_keys = ["_instantiator", "activation", "optimizer", "scheduler"]
883+
expected_instantiator = "lightning.pytorch.cli.instantiate_module"
884+
expected_activation = "torch.nn.LeakyReLU"
885+
expected_optimizer = "torch.optim.Adam"
886+
expected_scheduler = "torch.optim.lr_scheduler.ConstantLR"
887+
888+
assert sorted(hparams.keys()) == expected_keys
889+
assert hparams["_instantiator"] == expected_instantiator
890+
assert hparams["activation"]["class_path"] == expected_activation
891+
assert hparams["optimizer"] == expected_optimizer or hparams["optimizer"]["class_path"] == expected_optimizer
892+
assert hparams["scheduler"] == expected_scheduler or hparams["scheduler"]["class_path"] == expected_scheduler
888893

889894
checkpoint_path = next(Path(cli.trainer.log_dir, "checkpoints").glob("*.ckpt"), None)
890895
assert checkpoint_path.is_file()
891-
ckpt = torch.load(checkpoint_path, weights_only=True)
892-
assert ckpt["hyper_parameters"] == expected
896+
hparams = torch.load(checkpoint_path, weights_only=True)["hyper_parameters"]
897+
assert sorted(hparams.keys()) == expected_keys
898+
assert hparams["_instantiator"] == expected_instantiator
899+
assert hparams["activation"]["class_path"] == expected_activation
900+
assert hparams["optimizer"] == expected_optimizer or hparams["optimizer"]["class_path"] == expected_optimizer
901+
assert hparams["scheduler"] == expected_scheduler or hparams["scheduler"]["class_path"] == expected_scheduler
893902

894903
model = TestModelSaveHparams.load_from_checkpoint(checkpoint_path)
895904
assert isinstance(model, TestModelSaveHparams)
@@ -905,18 +914,23 @@ def test_lightning_cli_load_from_checkpoint_dependency_injection_subclass_mode(c
905914
cli = LightningCLI(TestModelSaveHparams, run=False, auto_configure_optimizers=False, subclass_mode_model=True)
906915
cli.trainer.fit(cli.model)
907916

908-
expected = {
909-
"_instantiator": "lightning.pytorch.cli.instantiate_module",
910-
"_class_path": f"{__name__}.TestModelSaveHparams",
911-
"optimizer": "torch.optim.Adam",
912-
"scheduler": "torch.optim.lr_scheduler.ConstantLR",
913-
"activation": {"class_path": "torch.nn.LeakyReLU", "init_args": {"negative_slope": 0.05, "inplace": False}},
914-
}
917+
expected_keys = ["_class_path", "_instantiator", "activation", "optimizer", "scheduler"]
918+
expected_instantiator = "lightning.pytorch.cli.instantiate_module"
919+
expected_class_path = f"{__name__}.TestModelSaveHparams"
920+
expected_activation = "torch.nn.LeakyReLU"
921+
expected_optimizer = "torch.optim.Adam"
922+
expected_scheduler = "torch.optim.lr_scheduler.ConstantLR"
915923

916924
checkpoint_path = next(Path(cli.trainer.log_dir, "checkpoints").glob("*.ckpt"), None)
917925
assert checkpoint_path.is_file()
918-
ckpt = torch.load(checkpoint_path, weights_only=True)
919-
assert ckpt["hyper_parameters"] == expected
926+
hparams = torch.load(checkpoint_path, weights_only=True)["hyper_parameters"]
927+
928+
assert sorted(hparams.keys()) == expected_keys
929+
assert hparams["_instantiator"] == expected_instantiator
930+
assert hparams["_class_path"] == expected_class_path
931+
assert hparams["activation"]["class_path"] == expected_activation
932+
assert hparams["optimizer"] == expected_optimizer or hparams["optimizer"]["class_path"] == expected_optimizer
933+
assert hparams["scheduler"] == expected_scheduler or hparams["scheduler"]["class_path"] == expected_scheduler
920934

921935
model = LightningModule.load_from_checkpoint(checkpoint_path)
922936
assert isinstance(model, TestModelSaveHparams)

tests/tests_pytorch/utilities/test_data.py

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from lightning.pytorch.trainer.states import RunningStage
1313
from lightning.pytorch.utilities.data import (
1414
_get_dataloader_init_args_and_kwargs,
15+
_is_dataloader_shuffled,
1516
_update_dataloader,
1617
extract_batch_size,
1718
has_len_all_ranks,
@@ -20,7 +21,7 @@
2021
from lightning.pytorch.utilities.exceptions import MisconfigurationException
2122
from lightning_utilities.test.warning import no_warning_call
2223
from torch import Tensor
23-
from torch.utils.data import BatchSampler, DataLoader, RandomSampler
24+
from torch.utils.data import BatchSampler, DataLoader, RandomSampler, SequentialSampler
2425

2526

2627
def test_extract_batch_size():
@@ -304,6 +305,31 @@ def __init__(self, extra_arg):
304305
_ = _update_dataloader(dataloader, dataloader.sampler, mode=RunningStage.PREDICTING)
305306

306307

308+
def test_batch_sampler_shuffle_setting():
309+
"""Test whether the `shuffle` state is correctly set in the `BatchSampler`."""
310+
311+
random_sampler = RandomSampler(range(10))
312+
seq_sampler = SequentialSampler(range(10))
313+
shuffled_dataloader = DataLoader(
314+
range(10), batch_sampler=BatchSampler(random_sampler, batch_size=2, drop_last=False)
315+
)
316+
sequential_dataloader = DataLoader(
317+
range(10), batch_sampler=BatchSampler(seq_sampler, batch_size=2, drop_last=False)
318+
)
319+
320+
# if batch_size is 1, the pytorch init a default SequentialSampler and set BatchSampler to None
321+
single_dataloader = DataLoader(range(10), batch_sampler=BatchSampler(seq_sampler, batch_size=1, drop_last=False))
322+
assert _is_dataloader_shuffled(shuffled_dataloader)
323+
assert not _is_dataloader_shuffled(sequential_dataloader)
324+
assert not _is_dataloader_shuffled(single_dataloader)
325+
326+
# if batch_size is 1, and no batch_sampler is set, the pytorch will set BatchSampler to None
327+
single_dataloader = DataLoader(range(10), batch_size=1)
328+
shuffled_single_dataloader = DataLoader(range(10), batch_size=1, shuffle=True)
329+
assert not _is_dataloader_shuffled(single_dataloader)
330+
assert _is_dataloader_shuffled(shuffled_single_dataloader)
331+
332+
307333
@pytest.mark.parametrize("mode", [RunningStage.TRAINING, RunningStage.PREDICTING, RunningStage.TESTING])
308334
def test_dataloader_kwargs_replacement_with_iterable_dataset(mode):
309335
"""Test that DataLoader kwargs are not replaced when using Iterable Dataset."""

0 commit comments

Comments
 (0)