Skip to content

Commit d623708

Browse files
committed
xfail tests for deprecated functionality
1 parent 4219f30 commit d623708

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

tests/tests_app/cli/test_cmd_install.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from lightning.app.testing.helpers import _RunIf
1010

1111

12+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
1213
@mock.patch("lightning.app.cli.cmd_install.subprocess", mock.MagicMock())
1314
def test_valid_org_app_name():
1415
"""Valid organization name."""
@@ -69,6 +70,7 @@ def test_app_install(tmpdir, monkeypatch):
6970
assert test_app_pip_name in str(new_env_output), f"{test_app_pip_name} should be in the env"
7071

7172

73+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
7274
@mock.patch("lightning.app.cli.cmd_install.subprocess", mock.MagicMock())
7375
def test_valid_org_component_name():
7476
runner = CliRunner()
@@ -135,6 +137,7 @@ def test_component_install(real_component, test_component_pip_name):
135137
), f"{test_component_pip_name} should not be in the env after cleanup"
136138

137139

140+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
138141
def test_prompt_actions():
139142
# TODO: each of these installs must check that a package is installed in the environment correctly
140143
app_to_use = "lightning/invideo"
@@ -164,6 +167,7 @@ def test_prompt_actions():
164167
# result = runner.invoke(lightning_cli.cmd_install.install_app, [app_to_use], input='')
165168

166169

170+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
167171
@mock.patch("lightning.app.cli.cmd_install.subprocess", mock.MagicMock())
168172
def test_version_arg_component(tmpdir, monkeypatch):
169173
monkeypatch.chdir(tmpdir)
@@ -186,6 +190,7 @@ def test_version_arg_component(tmpdir, monkeypatch):
186190
assert result.exit_code == 0
187191

188192

193+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
189194
@mock.patch("lightning.app.cli.cmd_install.subprocess", mock.MagicMock())
190195
@mock.patch("lightning.app.cli.cmd_install.os.chdir", mock.MagicMock())
191196
def test_version_arg_app(tmpdir):
@@ -237,6 +242,7 @@ def test_install_resolve_latest_version(mock_show_install_app_prompt, tmpdir):
237242
assert mock_show_install_app_prompt.call_args[0][0]["version"] == "0.0.4"
238243

239244

245+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
240246
def test_proper_url_parsing():
241247
name = "lightning/invideo"
242248

@@ -311,12 +317,14 @@ def test_install_app_shows_error(tmpdir):
311317
# os.chdir(cwd)
312318

313319

320+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
314321
def test_app_and_component_gallery_app(monkeypatch):
315322
monkeypatch.setattr(cmd_install, "_install_app_from_source", mock.MagicMock())
316323
path = cmd_install.gallery_apps_and_components("lightning/flashy", True, "latest")
317324
assert path == os.path.join(os.getcwd(), "app.py")
318325

319326

327+
@pytest.mark.xfail(strict=False, reason="lightning app cli was deprecated")
320328
def test_app_and_component_gallery_component(monkeypatch):
321329
monkeypatch.setattr(cmd_install, "_install_app_from_source", mock.MagicMock())
322330
path = cmd_install.gallery_apps_and_components("lightning/lit-jupyter", True, "latest")

0 commit comments

Comments
 (0)