Skip to content

Commit d838098

Browse files
committed
test: disable logger in model checkpoint tests to avoid side effects
1 parent 84fb3e1 commit d838098

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

tests/tests_pytorch/callbacks/test_model_checkpoint_additional_cases.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ def test_model_checkpoint_every_n_train_steps_with_train_metric_saves_at_step(tm
8484
limit_val_batches=0, # no validation needed for this test
8585
enable_checkpointing=True,
8686
enable_model_summary=False,
87+
logger=False,
8788
)
8889

8990
trainer.fit(model, train_dataloaders=train_loader, val_dataloaders=val_loader)
@@ -128,6 +129,7 @@ def test_model_checkpoint_time_interval_with_val_metric_defers_until_validation(
128129
limit_val_batches=1,
129130
enable_checkpointing=True,
130131
enable_model_summary=False,
132+
logger=False,
131133
)
132134

133135
trainer.fit(model, train_dataloaders=train_loader, val_dataloaders=val_loader)
@@ -194,6 +196,7 @@ def test_model_checkpoint_defer_until_next_validation_when_val_every_2_epochs(tm
194196
limit_val_batches=1,
195197
enable_checkpointing=True,
196198
enable_model_summary=False,
199+
logger=False,
197200
check_val_every_n_epoch=2, # only validate every 2 epochs
198201
)
199202

tests/tests_pytorch/callbacks/test_model_checkpoint_edge_cases.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ def test_checkpoint_defers_with_mid_epoch_validation(tmp_path, val_scores):
117117
limit_val_batches=1,
118118
enable_checkpointing=True,
119119
enable_model_summary=False,
120+
logger=False,
120121
val_check_interval=0.5,
121122
)
122123

@@ -161,6 +162,7 @@ def test_time_interval_defers_across_epoch_until_first_validation(tmp_path, val_
161162
limit_val_batches=1,
162163
enable_checkpointing=True,
163164
enable_model_summary=False,
165+
logger=False,
164166
check_val_every_n_epoch=2, # first validation only after 2nd epoch
165167
)
166168

tests/tests_pytorch/callbacks/test_model_checkpoint_step_interval_val_metric.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ def test_model_checkpoint_every_n_train_steps_with_val_metric_saves_after_val(tm
9191
limit_val_batches=1,
9292
enable_checkpointing=True,
9393
enable_model_summary=False,
94+
logger=False,
9495
)
9596

9697
trainer.fit(model, train_dataloaders=train_loader, val_dataloaders=val_loader)

0 commit comments

Comments
 (0)