Skip to content

Commit d9fdf20

Browse files
chore: Address review comments
1 parent 45273b7 commit d9fdf20

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/source-pytorch/visualize/supported_exp_managers.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ Configure the logger and pass it to the :class:`~lightning.pytorch.trainer.train
124124
)
125125
trainer = Trainer(logger=neptune_scale_logger)
126126

127-
Access the neptune scale logger from any function (except the LightningModule *init*) to use its API for tracking advanced artifacts
127+
Access the Neptune Scale logger from any function (except the LightningModule *init*) to use its API for tracking advanced artifacts
128128

129129
.. code-block:: python
130130

src/lightning/pytorch/loggers/neptune.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,7 @@ def after_save_checkpoint(self, checkpoint_callback: Checkpoint) -> None:
10851085
)
10861086

10871087
@staticmethod
1088-
def _get_full_model_name(model_path: str, checkpoint_callback: Checkpoint) -> str:
1088+
def _get_full_model_name(model_path: str, checkpoint_callback: Checkpoint) -> None:
10891089
"""Returns model name which is string `model_path` appended to `checkpoint_callback.dirpath`."""
10901090
return None
10911091
if hasattr(checkpoint_callback, "dirpath"):
@@ -1099,7 +1099,7 @@ def _get_full_model_name(model_path: str, checkpoint_callback: Checkpoint) -> st
10991099
return model_path.replace(os.sep, "/")
11001100

11011101
@classmethod
1102-
def _get_full_model_names_from_exp_structure(cls, exp_structure: dict[str, Any], namespace: str) -> set[str]:
1102+
def _get_full_model_names_from_exp_structure(cls, exp_structure: dict[str, Any], namespace: str) -> set[None]:
11031103
"""Returns all paths to properties which were already logged in `namespace`"""
11041104
return set()
11051105
structure_keys: list[str] = namespace.split(cls.LOGGER_JOIN_CHAR)

0 commit comments

Comments
 (0)