Skip to content

Commit dfb6d36

Browse files
neggertwilliamFalcon
authored andcommitted
Fix failing GPU tests (#722)
* Fix distributed_backend=None test We now throw a warning instead of an exception. Update test to reflect this. * Fix test_tube logger close when debug=True
1 parent ca894f0 commit dfb6d36

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

pytorch_lightning/logging/test_tube.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,9 @@ def finalize(self, status):
135135
def close(self):
136136
# TODO: HACK figure out where this is being set to true
137137
self.experiment.debug = self.debug
138-
exp = self.experiment
139-
exp.close()
138+
if not self.debug:
139+
exp = self.experiment
140+
exp.close()
140141

141142
@property
142143
def rank(self):

tests/test_gpu_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def test_multi_gpu_none_backend(tmpdir):
183183
gpus='-1'
184184
)
185185

186-
with pytest.raises(MisconfigurationException):
186+
with pytest.warns(UserWarning):
187187
tutils.run_model_test(trainer_options, model)
188188

189189

0 commit comments

Comments
 (0)