Commit e058cee
committed
refactor(Rich): Centralize _RICH_AVAILABLE and version check
Addresses a PR comment by bhimrazy regarding inconsistent _RICH_AVAILABLE checks.
This commit:
1. Defines _RICH_MIN_VERSION = "10.2.2" in utilities/imports.py.
2. Updates _RICH_AVAILABLE in utilities/imports.py to use this minimum version.
3. Modifies callbacks/progress/rich_progress.py to import and use the centralized _RICH_AVAILABLE from utilities/imports.py, removing its local definition.
This ensures a single source of truth for rich package availability and version checking.1 parent eaa6b00 commit e058cee
File tree
2 files changed
+3
-4
lines changed- src/lightning/pytorch
- callbacks/progress
- utilities
2 files changed
+3
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
30 | 28 | | |
31 | 29 | | |
32 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
0 commit comments