_XFAIL_GLOO_WINDOWS

Author: Borda

tests/tests_pytorch/callbacks/test_spike.py

@@ -3,12 +3,11 @@
 import pytest
 import torch
 
-from lightning.fabric.utilities.imports import _IS_WINDOWS, _TORCHMETRICS_GREATER_EQUAL_1_0_0
+from lightning.fabric.utilities.imports import _TORCHMETRICS_GREATER_EQUAL_1_0_0
 from lightning.fabric.utilities.spike import TrainingSpikeException
 from lightning.pytorch import LightningModule, Trainer
 from lightning.pytorch.callbacks.spike import SpikeDetection
-from lightning.pytorch.utilities.imports import _TORCH_GREATER_EQUAL_2_8
-from tests_pytorch.helpers.runif import RunIf
+from tests_pytorch.helpers.runif import _XFAIL_GLOO_WINDOWS, RunIf
 
 
 class IdentityModule(LightningModule):
@@ -49,10 +48,6 @@ def on_train_batch_end(self, trainer, pl_module, outputs, batch, batch_idx):
             super().on_train_batch_end(trainer, pl_module, outputs, batch, batch_idx)
 
 
-# todo: RuntimeError: makeDeviceForHostname(): unsupported gloo device
-_XFAIL_GLOO_WINDOWS = pytest.mark.xfail(RuntimeError, strict=True, condition=(_IS_WINDOWS and _TORCH_GREATER_EQUAL_2_8))
-
-
 @pytest.mark.flaky(max_runs=3)
 @pytest.mark.parametrize(
     ("global_rank_spike", "num_devices", "spike_value", "finite_only"),

tests/tests_pytorch/helpers/runif.py

@@ -13,9 +13,20 @@
 # limitations under the License.
 import pytest
 
+from lightning.fabric.utilities.imports import _IS_WINDOWS
+from lightning.pytorch.utilities.imports import _TORCH_GREATER_EQUAL_2_8
 from lightning.pytorch.utilities.testing import _runif_reasons
 
 
 def RunIf(**kwargs):
     reasons, marker_kwargs = _runif_reasons(**kwargs)
     return pytest.mark.skipif(condition=len(reasons) > 0, reason=f"Requires: [{' + '.join(reasons)}]", **marker_kwargs)
+
+
+# todo: RuntimeError: makeDeviceForHostname(): unsupported gloo device
+_XFAIL_GLOO_WINDOWS = pytest.mark.xfail(
+    RuntimeError,
+    strict=True,
+    condition=(_IS_WINDOWS and _TORCH_GREATER_EQUAL_2_8),
+    reason="makeDeviceForHostname(): unsupported gloo device",
+)