Skip to content

Commit ec39fe5

Browse files
committed
fix mypy
1 parent c45fa9b commit ec39fe5

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/lightning/pytorch/loggers/utilities.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,16 @@ def extend(self, __iterable: Iterable[_T]) -> None:
173173
self._dict[key] = idx + offset
174174
super().extend(__iterable)
175175

176-
def pop(self, key: Union[SupportsIndex, str] = -1, default: Optional[_T, _PT] = None) -> Optional[Union[_T, _PT]]:
176+
@overload
177+
def pop(self, key: SupportsIndex = -1, /) -> _T: ...
178+
179+
@overload
180+
def pop(self, key: str, /, default: _T) -> _T: ...
181+
182+
@overload
183+
def pop(self, key: str, default: _PT, /) -> Union[_T, _PT]: ...
184+
185+
def pop(self, key=-1, default=None):
177186
if isinstance(key, int):
178187
ret = list.pop(self, key)
179188
for str_key, idx in list(self._dict.items()):

0 commit comments

Comments
 (0)