TrainerDataLoadingMixin.request_dataloader
#10679
Unanswered
daniellepintz
asked this question in
Lightning Trainer API: Trainer, LightningModule, LightningDataModule
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Can we mark
TrainerDataLoadingMixin.request_dataloader
as protected?https://github.com/PyTorchLightning/pytorch-lightning/blob/dcafc95f2b0fd3f176d425139ca99676ce943a12/pytorch_lightning/trainer/data_loading.py#L566-L582
Can we remove the
model
arg fromTrainerDataLoadingMixin.request_dataloader
? Can we assume that whenever we callrequest_dataloader
the Trainer already has a model attached?Motivation
We are redesigning the Trainer's
call_hook
method and would like to not have the LM as an argument to the method; in order to do that we need to not pass the LM here:https://github.com/PyTorchLightning/pytorch-lightning/blob/dcafc95f2b0fd3f176d425139ca99676ce943a12/pytorch_lightning/trainer/data_loading.py#L577
Beta Was this translation helpful? Give feedback.
All reactions