Self.log doesn’t work in PyTorch Lightning in custom logger

[alihejrati]

I create a custom Logger module like the one below, and when I call self.log in training_step nothing happens. only MyLogger.save method is called and I don’t get metrics.
when I set log_every_n_steps=1 in Trainer() then MyLogger.log_metrics is called and shows learning_rate instead metrics I logged in self.log_dict

my custom logger:

def __init__(
    self, 
    save_dir: str = None,
    name: Optional[str] = 'GeineLogger',
    version: str = '0.1',
    **kwargs: Any
):
    super().__init__(**kwargs)
    self._save_dir = save_dir
    self._name = name

@property
def name(self):
    return self._name

@property
def save_dir(self) -> Optional[str]:
    return self._save_dir

@rank_zero_only
def log_hyperparams(self, params):
    logger.critical('log_hyperparams | params={}'.format(params))

@rank_zero_only
def log_metrics(self, metrics, step):
    logger.critical('log_metrics | metrics={} | step={}'.format(metrics, step))

@rank_zero_only
def save(self):
    super().save()
    logger.critical('save')

@rank_zero_only
def finalize(self, status):
    super().finalize(status)
    logger.critical('finalize | status={}'.format(status))

training function:

def training_step(self, batch, batch_idx, optimizer_idx):
        print(self.trainer._results)
        x = self.get_input(batch, self.image_key)
        xrec, qloss = self(x)

        if optimizer_idx == 0:
            # autoencode
            aeloss, log_dict_ae = self.loss(qloss, x, xrec, optimizer_idx, self.global_step, last_layer=self.get_last_layer(), split="train")

            self.log("train/aeloss", aeloss, prog_bar=True, logger=True, on_step=True, on_epoch=True)
            self.log_dict(log_dict_ae, prog_bar=False, logger=True, on_step=True, on_epoch=True)
            return aeloss

        if optimizer_idx == 1:
            # discriminator
            discloss, log_dict_disc = self.loss(qloss, x, xrec, optimizer_idx, self.global_step, last_layer=self.get_last_layer(), split="train")
            self.log("train/discloss", discloss, prog_bar=True, logger=True, on_step=True, on_epoch=True)
            self.log_dict(log_dict_disc, prog_bar=False, logger=True, on_step=True, on_epoch=True)
            return discloses

I get this instead log_dict content!