loop api naming

[awaelchli]

@Borda suggested the following for the API naming in new loops:

Loop.is_done instead of Loop.done
Loop.should_skip instead of Loop.skip

Note, these are properties, not methods.

Do you prefer the longer name (less ambiguous) or shorter name (easier to remember)

@justusschock @ananthsub @tchaton @Borda

Vote:

• short names 🚀
• long names 🎉

[Borda]

Note, these are properties, not methods.

that is true, so maybe the () make the job of separation action from the state...
probably keep just skip but would prefer the is_ when you ask about state and return bool

[tchaton]

IMO, I prefer the current approach for the done property as this is going to be used in a negative form.

while not loop.is_done

while not is done doesn't sound right compared to while not done.

For skip, I think Loop.should_skipseems better.

Best,
T.C