-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
fabriclightning.fabric.Fabriclightning.fabric.FabricfeatureIs an improvement or enhancementIs an improvement or enhancementhelp wantedOpen to be worked onOpen to be worked on
Milestone
Description
Description & Motivation
We added a new API for loading in Fabric in #16434. The loading of the module parameters currently uses just strict=True
.
Pitch
Make it an argument. See todo notes in code here:
https://github.com/Lightning-AI/lightning/blob/39acb81b9bd01139f7cead31c673f25ba330f2f1/src/lightning_fabric/strategies/strategy.py#L270-L273
and here:
This may not be valid for all strategies. Thus, the argument type should probably be Optional[bool] = None
.
Alternatives
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
fabriclightning.fabric.Fabriclightning.fabric.FabricfeatureIs an improvement or enhancementIs an improvement or enhancementhelp wantedOpen to be worked onOpen to be worked on