Apply the ignore of the `save_hyperparameters` function to args

[doveppp]

Description & Motivation

Currently, the ignore parameter of the save_hyperparameters function only filters its own arguments.

Can we apply hp = {k: v for k, v in hp.items() if k not in ignore} before obj._set_hparams(hp)?

Pitch

No response

Alternatives

No response

Additional context

No response

cc @Borda

[aseemk98]

I'll take this up.

[vgauraha62]

hey did you resolve this issue?

[22ema]

I'll take this up.

[kushagragpt99]

Hey! Is this issue still open? I checked the PR #20213 and it's still open. I'd love to contribute if it's still open.

[deependujha]

Hi @doveppp, it already filters. collect_init_args recursively collects all the arguments passed to __init__ method. And, then we filter ignore from it.

We don't need to again filter it (as per your suggestion).