-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Open
Labels
fabriclightning.fabric.Fabriclightning.fabric.FabricfeatureIs an improvement or enhancementIs an improvement or enhancement
Description
Description & Motivation
In Fabric run CLI, the script argument always assumes the input is an existed file path. However, users might need to launch a python module.
type=click.Path(exists=True), |
For example, the CLI expects
fabric run src/run.py \
--strategy=ddp \
--devices=2 \
--accelerator=cuda
However, this would fail
fabric run \
--strategy=ddp \
--devices=2 \
--accelerator=cuda \
-m src.run
In huggingface accelearte, they provide an extra argument for definiing an module
https://github.com/huggingface/accelerate/blob/4b6be8991059f39a8df8893333d11c54bc51fc60/src/accelerate/commands/launch.py#L358
Pitch
No response
Alternatives
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
fabriclightning.fabric.Fabriclightning.fabric.FabricfeatureIs an improvement or enhancementIs an improvement or enhancement