-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
bugSomething isn't workingSomething isn't workingneeds triageWaiting to be triaged by maintainersWaiting to be triaged by maintainersver: 2.1.xver: 2.2.xver: 2.3.xver: 2.4.xver: 2.5.x
Description
Bug description
Is there a reason for lightning requiring packaging < 25.0 ?
The last lightning release allowing an install with packaging==25.0 is lightning==1.8.6 (try pip install lightning==1.8.6 packaging==25.0
, it works !)
Yet packaging 25.0 does not seem to be revolutionary...
So may be you could remove the upper limit on packaging ?
By the way, I'm not very found of upper limits in dependencies, unless you are sure there will be a problem with the next releases of your dependencies... This was probably not the case here, as the release 25.0 of packaging did not exist when you choose to set packaging<25.0
in your dependencies...
What version are you seeing the problem on?
v2.5, v2.4, v2.3, v2.2, v2.1
How to reproduce the bug
for example :
pip install lightning==2.5.1.post0 packaging==25.0
Error messages and logs
ERROR: Cannot install lightning==2.5.1.post0 and packaging==25.0 because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested packaging==25.0
lightning 2.5.1.post0 depends on packaging<25.0 and >=20.0
Environment
No response
More info
No response
lorinczszabolcs
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingneeds triageWaiting to be triaged by maintainersWaiting to be triaged by maintainersver: 2.1.xver: 2.2.xver: 2.3.xver: 2.4.xver: 2.5.x