fix: Set tensorboard's global_step as the default wandb x-axis if sync_tensorboard=True
#20611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f sync_tensorboard=True there isn't a need to create another global_step if you are syncing from tensorboard
ringohoffman
requested review from
Borda,
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
ringohoffman
changed the title
tensorboard's global_step as the default wandb x-axis if sync_tensorboard=Truetensorboard's global_step as the default wandb x-axis if sync_tensorboard=True
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20611 +/- ##
=========================================
- Coverage 88% 79% -9%
=========================================
Files 267 264 -3
Lines 23369 23316 -53
=========================================
- Hits 20478 18371 -2107
- Misses 2891 4945 +2054 |
|
cc: @Borda |
Borda
changed the title
tensorboard's global_step as the default wandb x-axis if sync_tensorboard=Truetensorboard's global_step as the default wandb x-axis if sync_tensorboard=True
Borda
added
logger
|
Any thoughts on this? |
Borda
changed the title
tensorboard's global_step as the default wandb x-axis if sync_tensorboard=Truetensorboard's global_step as the default wandb x-axis if sync_tensorboard=True
Borda
approved these changes
Mar 10, 2025
|
It looks like 2 tests timed out. Can they be retried? |
ringohoffman
deleted the
set-global_step-default-wandb-x-axis-sync_tensorboard=True
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There isn't a need to create
trainer/global_stepif you are syncing fromtensorboardwithsync_tensorboard=True.Since I use
TensorboardLoggeras my main logger and sync it towandbwithWandbLogger(sync_tensorboard=True), in my case,WandbLogger.log_metricsis never called, andtrainer/global_stepis never updated. All of mywandbare shown as a single point by default, and I have to manually update my workspace/plots to useglobal_step.global_steptrainer/global_stepIt makes a lot more sense to just default to
global_stepas the x-axis ifsync_tensorboard=True.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20611.org.readthedocs.build/en/20611/