From d861366f2f93402603cd95c73b74ccbf367d60ed Mon Sep 17 00:00:00 2001 From: "Adam J. Stewart" Date: Wed, 7 May 2025 12:04:14 +0200 Subject: [PATCH 1/2] CLI: resolve jsonargparse deprecation warning --- src/lightning/pytorch/cli.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/lightning/pytorch/cli.py b/src/lightning/pytorch/cli.py index 75a6347c95356..bb736022e4cea 100644 --- a/src/lightning/pytorch/cli.py +++ b/src/lightning/pytorch/cli.py @@ -45,11 +45,16 @@ Namespace, class_from_function, register_unresolvable_import_paths, - set_config_read_mode, ) register_unresolvable_import_paths(torch) # Required until fix https://github.com/pytorch/pytorch/issues/74483 - set_config_read_mode(fsspec_enabled=True) + + try: + from jsonargparse import set_parsing_settings + set_parsing_settings(config_read_mode_fsspec_enabled=True) + except ImportError: + from jsonargparse import set_config_read_mode + set_config_read_mode(fsspec_enabled=True) else: locals()["ArgumentParser"] = object locals()["Namespace"] = object From 1305186ce0001d9bc8d160b53528ff8bea4d8a78 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 7 May 2025 10:11:47 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/lightning/pytorch/cli.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lightning/pytorch/cli.py b/src/lightning/pytorch/cli.py index bb736022e4cea..8e64b8aba1b73 100644 --- a/src/lightning/pytorch/cli.py +++ b/src/lightning/pytorch/cli.py @@ -51,9 +51,11 @@ try: from jsonargparse import set_parsing_settings + set_parsing_settings(config_read_mode_fsspec_enabled=True) except ImportError: from jsonargparse import set_config_read_mode + set_config_read_mode(fsspec_enabled=True) else: locals()["ArgumentParser"] = object