Skip to content

debugging flaky test_collective_operations with SIGABRT #20912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025
Merged

debugging flaky test_collective_operations with SIGABRT #20912

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7d5d49
Add flaky test marker for collective operations and implement changel…
Borda Jun 17, 2025
4658409
try GLOO_SOCKET_IFNAME: "eth0"
Borda Jun 17, 2025
8ac0a9e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 17, 2025
f84fd7f
more
Borda Jun 17, 2025
ffa5aaa
Merge branch 'flaky/test_collective_operations' of https://github.com…
Borda Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/ci-tests-fabric.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,16 +116,24 @@ jobs:
mkdir -p $PYPI_CACHE_DIR
ls -lh $PYPI_CACHE_DIR

- name: Env. variables
- name: Expand Env. variables
run: |
# Switch PyTorch URL between stable and test/future
python -c "print('TORCH_URL=' + str('${{env.TORCH_URL_TEST}}' if '${{ matrix.pytorch-version }}' == '2.7' else '${{env.TORCH_URL_STABLE}}'))" >> $GITHUB_ENV
# Switch coverage scope
python -c "print('COVERAGE_SCOPE=' + str('lightning' if '${{matrix.pkg-name}}' == 'lightning' else 'lightning_fabric'))" >> $GITHUB_ENV
# if you install mono-package set dependency only for this subpackage
python -c "print('EXTRA_PREFIX=' + str('' if '${{matrix.pkg-name}}' != 'lightning' else 'fabric-'))" >> $GITHUB_ENV
- name: Append Env. vars for MacOS
if: ${{ runner.os == 'macOS' }}
run: |
# trying to avoid "gloo" issue with SIGABRT
echo "GLOO_SOCKET_IFNAME=lo0" >> $GITHUB_ENV
- name: Append Env. vars for Windows
if: ${{ runner.os == 'windows' }}
run: |
# Avoid issue on Windows with PyTorch 2.4: "RuntimeError: use_libuv was requested but PyTorch was build without libuv support"
python -c "print('USE_LIBUV=0' if '${{matrix.os}}' == 'windows-2022' and '${{matrix.pytorch-version}}' == '2.4' else '')" >> $GITHUB_ENV
echo "USE_LIBUV=0" >> $GITHUB_ENV

- name: Install package & dependencies
timeout-minutes: 20
Expand Down
Loading