Make asyncio checkpointing work if validate/fit is called more than once #20952
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjh42
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
Borda
changed the title
|
let me know if this looks ok and then I'll fix the mypy errors. |
|
any feedback? is it worth spending time fixing mypy / conflict or there is no interest in this (I would say the more serious issue is the linked issue which seems like it could result in checkpoints which are degraded). |
Isalia20
reviewed
Aug 8, 2025
Comment on lines
+39
to
+41
| # CheckpointIO doesn't have a setup method so we have to do something like. | ||
| # We can't do setup in __init__ because if train or validate is called more than once the | ||
| # teardown method deletes the executor. |
There was a problem hiding this comment.
I think we can put this in a function's docstring?
Borda
reviewed
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently if using async checkpointing if fit or validate is called than once it will crash (because the threadpool is shutdown and never re-created).
This PR modifies the test to induce the crash and fixes it.
No.
Was this discussed/agreed via a GitHub issue? (not for typos and docs)
No, this is just a bugfix, not a behavior change. Should I create an issue?
Did you read the contributor guideline, Pull Request section?
Yes
Did you make sure your PR does only one thing, instead of bundling different changes together?
Yes
Did you make sure to update the documentation with your changes? (if necessary)
na
Did you write any new necessary tests? (not for typos and docs)
yes
Did you verify new and existing tests pass locally with your changes?
as best I could, I'm not very clear the recommended setup for testing pytorch lightning locally, I was only able to run the test I modified.
Did you list all the breaking changes introduced by this pull request?
na
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)
Yes
📚 Documentation preview 📚: https://pytorch-lightning--20952.org.readthedocs.build/en/20952/