Skip to content

Conversation

@SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Jul 28, 2025

What does this PR do?

Fixes #20303
Fix single location in documentation where model.learning_rate is reference after loading a checkpoint. Should instead be model.hparams.learning_rate.

and...

Fixes #20622
The specific problems mentioned in this issue are already resolved in another PR, however similar problems could be found in two example scripts. Namely that the order of arguments to fabric.save was switched. Solved this.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21013.org.readthedocs.build/en/21013/

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jul 28, 2025
@Borda Borda merged commit 89dbc55 into Lightning-AI:master Aug 5, 2025
22 checks passed
Borda pushed a commit that referenced this pull request Aug 13, 2025
* fix examples
* fix reference to hparams
* use kwargs

(cherry picked from commit 89dbc55)
Borda pushed a commit that referenced this pull request Aug 13, 2025
* fix examples
* fix reference to hparams
* use kwargs

(cherry picked from commit 89dbc55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

5 participants