releasing 2.5.5 [rebase & merge]
#21152
Conversation
* docs: simplify version table * Apply suggestions from code review * update (cherry picked from commit 691f084)
[create-pull-request] automated change Co-authored-by: Borda <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 0ebf1dd)
* pip uninstall -y deepspeed * TORCH_VER * Apply suggestions from code review * A100 & L4 * machine (cherry picked from commit d85c474)
… validation metrics are available (#21106) * fix(callbacks): defer step/time-triggered ModelCheckpoint saves until validation metrics are available Root cause: - With `every_n_train_steps` (or `train_time_interval`), checkpoints could save at train batch end before validation ran, so the monitored val metric was missing/stale and `best_model_score` was incorrect. (Refs #20919) Fix: - In [src/lightning/pytorch/callbacks/model_checkpoint.py:ModelCheckpoint.on_train_batch_end]: - Defer saves when the monitored key is missing from [trainer.callback_metrics] - If on the last train batch and not saving at train-epoch-end, defer only when validation will run next: - `trainer.enable_validation` is True - `trainer.num_val_batches` > 0 - `trainer.check_val_every_n_epoch` schedule matches the upcoming epoch - Perform deferred saves in [on_validation_end], ensuring fresh validation metrics are used. - Allow zero `timedelta` for `train_time_interval` and broadcast the time-trigger decision across ranks. - Do not defer when monitoring a train metric or when no validation is scheduled. Tests: - Repro (previously failing, now passing): - [tests/tests_pytorch/callbacks/test_model_checkpoint_step_interval_val_metric.py] - Additional validations: - [tests/tests_pytorch/callbacks/test_model_checkpoint_additional_cases.py] - [tests/tests_pytorch/callbacks/test_model_checkpoint_edge_cases.py] Outcome: - `best_model_score` matches the validation metric after the epoch. - Step/time-interval checkpointing behaves correctly without premature or skipped saves. * test: disable logger in model checkpoint tests to avoid side effects * chlog --------- Co-authored-by: Jirka B <[email protected]> (cherry picked from commit b1cc925)
Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2 to 3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2...v3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit c504088)
) Bumps [google-github-actions/setup-gcloud](https://github.com/google-github-actions/setup-gcloud) from 2 to 3. - [Release notes](https://github.com/google-github-actions/setup-gcloud/releases) - [Changelog](https://github.com/google-github-actions/setup-gcloud/blob/main/CHANGELOG.md) - [Commits](google-github-actions/setup-gcloud@v2...v3) --- updated-dependencies: - dependency-name: google-github-actions/setup-gcloud dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 9a41f1f)
….0 in /requirements (#21134) build(deps): update ipython[notebook] requirement in /requirements Updates the requirements on [ipython[notebook]](https://github.com/ipython/ipython) to permit the latest version. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@rel-0.8.4...9.5.0) --- updated-dependencies: - dependency-name: ipython[notebook] dependency-version: 9.5.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 2e4c99c)
…1135) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.10.5 to 7.10.6. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.10.5...7.10.6) --- updated-dependencies: - dependency-name: coverage dependency-version: 7.10.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit a93a5bb)
…ents (#21137) build(deps): bump pytest-rerunfailures in /requirements Bumps [pytest-rerunfailures](https://github.com/pytest-dev/pytest-rerunfailures) from 15.1 to 16.0. - [Changelog](https://github.com/pytest-dev/pytest-rerunfailures/blob/master/CHANGES.rst) - [Commits](pytest-dev/pytest-rerunfailures@15.1...16.0) --- updated-dependencies: - dependency-name: pytest-rerunfailures dependency-version: '16.0' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 824dfb1)
…<1.20.0 in /requirements (#21136) build(deps): update onnx requirement in /requirements Updates the requirements on [onnx](https://github.com/onnx/onnx) to permit the latest version. - [Release notes](https://github.com/onnx/onnx/releases) - [Changelog](https://github.com/onnx/onnx/blob/main/docs/Changelog-ml.md) - [Commits](onnx/onnx@v1.13.0...v1.19.0) --- updated-dependencies: - dependency-name: onnx dependency-version: 1.19.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 9ace8b7)
… to >4.5.0,<4.16.0 in /requirements (#21133) build(deps): update typing-extensions requirement in /requirements Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.6.0...4.15.0) --- updated-dependencies: - dependency-name: typing-extensions dependency-version: 4.15.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 46445cb)
* simplify * add config field (cherry picked from commit db77fa7)
* add hook order * add to index * Apply suggestions from code review * BoringModel * testoutput --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 3d56296)
* add missing device id for pytorch 2.8 * skip device id for older pytorch versions * add testing * fix mypy without touching submodule * fix failing tests * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Deependu <[email protected]> Co-authored-by: Jirka B <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6fc44c9)
(cherry picked from commit e760ad5)
…n /requirements (#21138) * build(deps): update ipython[all] requirement in /requirements Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@rel-0.8.4...9.5.0) --- updated-dependencies: - dependency-name: ipython[all] dependency-version: 9.5.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Apply suggestions from code review --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit da7f2f9)
) (cherry picked from commit 06bed20)
* docs: move `on_fit_end` hook to `teardown` stage. * Apply suggestion from @bhimrazy --------- Co-authored-by: Bhimraj Yadav <[email protected]> (cherry picked from commit 630db82)
* add warning * tests * changelog * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Deependu <[email protected]> (cherry picked from commit 90eba3f)
Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit c3ca8a5)
…te classes (#21116) * Fix LightningCLI not using ckpt_path hyperparameters to instantiate classes * Add message about ckpt_path hyperparameters when parsing fails * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 4824cc1)
* add to deepspeed strategies * add testing * changelog * GLOO_SOCKET_IFNAME --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 5071a04)
* improve gpu_faq * add per device text * header * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit d3996ad)
* Disable cache for torch.autocast in amp * Add a test * Only test for bf16-mixed * Implement test to reproduce the issue --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 216f9ec)
…nd `Trainer` methods (#20864) * Update profiler.rst * move documentation to basic --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 04e103b)
* swap to uv * no pip cache * enable caching. use venv. * activate environment * fix uninstall * replace pip with uv * activate venv * --find-links=... * GLOO_SOCKET_IFNAME --------- Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 29e8ce4)
* DOC: Clarify DeviceStatsMonitor logged metrics (#20807) * update * use nested list * Apply suggestions from code review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka B <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Nicki Skafte <[email protected]> (cherry picked from commit 9f757c0)
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/stable #21152 +/- ##
===============================================
Coverage 87% 87%
===============================================
Files 268 268
Lines 23363 23456 +93
===============================================
+ Hits 20356 20446 +90
- Misses 3007 3010 +3 |
Signed-off-by: slicesequal <[email protected]> (cherry picked from commit 10f10b6)
Borda
force-pushed
the
releasing/2.5.5
branch
6 times, most recently
from
c0c8485 to
c2e7c38
Compare
Borda
force-pushed
the
releasing/2.5.5
branch
from
c2e7c38 to
61c9aa9
Compare
…#21161) * Update test_mlflow.py * test_mlflow.py * Respect verbose flag in seed_everything * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit d6499ed)
* Make sure temp checkpoints are cleaned up on failed tuning * add testing * changelog --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit e1e2534)
(cherry picked from commit bb4769f)
* let `_get_default_process_group_backend_for_device` support more hardware platforms (#21057) * support more hardware platforms and no longer hard code cuda when call _get_default_process_group_backend_for_device * Apply suggestions from code review --------- * try it * chlog --------- Signed-off-by: taozhiwei <[email protected]> Co-authored-by: taozhiwei <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 3c81316)
Borda
force-pushed
the
releasing/2.5.5
branch
from
61c9aa9 to
4cc68dc
Compare
Borda
force-pushed
the
releasing/2.5.5
branch
from
4cc68dc to
88c3591
Compare
What does this PR do?
regular patch release
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21152.org.readthedocs.build/en/21152/