Skip to content

tests: ignore future warning for oldest configurations #21185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 8, 2025
Merged

tests: ignore future warning for oldest configurations #21185

merged 10 commits into from
Sep 8, 2025

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Sep 8, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Testing Future warning for minimal/oldest dependencies is false case
It's almost sure that the min configuration will or should raise warnings

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21185.org.readthedocs.build/en/21185/

@Borda Borda requested a review from Copilot September 8, 2025 18:35
@github-actions github-actions bot added ci Continuous Integration package labels Sep 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success ✅

These checks are required after the changes to .actions/assistant.py, .github/workflows/ci-tests-pytorch.yml, pyproject.toml.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | oldest) success ✅
pytorch-lightning (GPUs) (testing PyTorch | latest) success ✅

These checks are required after the changes to .actions/assistant.py, pyproject.toml.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to .actions/assistant.py, pyproject.toml.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1.2, 12.1.1) success ✅
build-cuda (3.11, 2.2.2, 12.1.1) success ✅
build-cuda (3.11, 2.3.1, 12.1.1) success ✅
build-cuda (3.11, 2.4.1, 12.1.1) success ✅
build-cuda (3.12, 2.5.1, 12.1.1) success ✅
build-cuda (3.12, 2.6.0, 12.4.1) success ✅
build-pl (3.10, 2.1, 12.1.1) success ✅
build-pl (3.11, 2.2, 12.1.1) success ✅
build-pl (3.11, 2.3, 12.1.1) success ✅
build-pl (3.11, 2.4, 12.1.1) success ✅
build-pl (3.12, 2.5, 12.1.1) success ✅
build-pl (3.12, 2.6, 12.4.1) success ✅
build-pl (3.12, 2.7, 12.6.3) success ✅
build-pl (3.12, 2.8, 12.6.3, true) success ✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success ✅

These checks are required after the changes to .actions/assistant.py, pyproject.toml, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | oldest) success ✅
lightning-fabric (GPUs) (testing Fabric | latest) success ✅
lightning-fabric (GPUs) (testing Lightning | latest) success ✅

These checks are required after the changes to .actions/assistant.py, pyproject.toml.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to .actions/assistant.py, requirements/ci.txt, pyproject.toml.

🟢 install
Check ID Status
install-pkg-guardian success ✅

These checks are required after the changes to .actions/assistant.py, requirements/ci.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Sep 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (75a6bf7) to head (e46a70d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21185   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         269      269           
  Lines       23656    23656           
=======================================
- Hits        20636    20633    -3     
- Misses       3020     3023    +3

Copilot
Copilot AI reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the testing configuration to ignore FutureWarnings when testing with the oldest supported dependency versions. The changes recognize that minimal/oldest dependency configurations are expected to generate FutureWarnings and should not fail tests due to these warnings.

  • Removes a specific pynvml deprecation warning filter from the main test configuration
  • Adds sed commands to CI workflows to automatically remove FutureWarning error filters when testing oldest dependencies

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Removes specific pynvml FutureWarning ignore filter from test configuration
.github/workflows/ci-tests-pytorch.yml Adds sed command to remove FutureWarning error filters for oldest dependency testing
.github/workflows/ci-tests-fabric.yml Adds sed command to remove FutureWarning error filters for oldest dependency testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 8, 2025
@Borda Borda merged commit cd30ce4 into master Sep 8, 2025
180 of 182 checks passed
@Borda Borda deleted the ci/oldest-FutureWarning branch September 8, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tchaton tchaton tchaton approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @tchaton