This repository was archived by the owner on Aug 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Allow PR with notebooks #34
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
🚀 Feature
Simplify the user work such as passing the notebooks and we would internally convert to scripts and cleaned formating
Motivation
Less user flustration and smoother user experience as performing review in https://www.reviewnb.com
Alternatives
Add extra workflows to handle these situations
- these notebooks will go to another branch staging
- on PR to this special branch we run standard notebooks testing
- on merge (commit to
staging) we trigger converting to script and merge to main or create a new PR? (we new PR we have extra level safety and also most likely no actions will be triggered on bots merge event) - ISSUE: how to ensure that in the staging branch is only one notebook - after converting we re-create blank
stagingfrommain
Additional context
@edgarriba is not happy about converting notebooks to script and fixing issues on his own :P
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed