implement feedback

Author: ananas-block

Cargo.toml

@@ -185,9 +185,9 @@ account-compression = { path = "programs/account-compression", version = "2.0.0"
 light-compressed-token = { path = "programs/compressed-token/program", version = "2.0.0", features = [
     "cpi",
 ] }
-light-compressed-token-types = { path = "sdk-libs/compressed-token-types" }
-light-compressed-token-sdk = { path = "sdk-libs/compressed-token-sdk" }
-light-token-client = { path = "sdk-libs/token-client" }
+light-compressed-token-types = { path = "sdk-libs/compressed-token-types", version = "0.1.0" }
+light-compressed-token-sdk = { path = "sdk-libs/compressed-token-sdk", version = "0.1.0" }
+light-token-client = { path = "sdk-libs/token-client", version = "0.1.0" }
 light-system-program-anchor = { path = "anchor-programs/system", version = "2.0.0", features = [
     "cpi",
 ] }

program-libs/ctoken-types/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "light-ctoken-types"
-version = { workspace = true }
+version = "0.1.0"
 edition = { workspace = true }
 
 [features]

program-libs/ctoken-types/tests/token_data.rs

@@ -52,7 +52,8 @@ fn equivalency_of_hash_functions() {
 fn legacy_hash(token_data: &TokenData) -> std::result::Result<[u8; 32], HasherError> {
     let hashed_mint = hash_to_bn254_field_size_be(token_data.mint.to_bytes().as_slice());
     let hashed_owner = hash_to_bn254_field_size_be(token_data.owner.to_bytes().as_slice());
-    let amount_bytes = token_data.amount.to_le_bytes();
+    let mut amount_bytes = [0u8; 32];
+    amount_bytes[24..].copy_from_slice(token_data.amount.to_le_bytes().as_slice());
     let hashed_delegate;
     let hashed_delegate_option = if let Some(delegate) = token_data.delegate {
         hashed_delegate = hash_to_bn254_field_size_be(delegate.to_bytes().as_slice());

programs/compressed-token/anchor/src/lib.rs

@@ -379,6 +379,8 @@ pub enum ErrorCode {
     Transfer2InvalidChangeAccountData,
     #[msg("Cpi context expected but not provided.")]
     CpiContextExpected,
+    #[msg("CPI accounts slice exceeds provided account infos")]
+    CpiAccountsSliceOutOfBounds,
 }
 
 impl From<ErrorCode> for ProgramError {

programs/compressed-token/program/src/mint_action/accounts.rs

@@ -274,11 +274,15 @@ impl<'info> MintActionAccounts<'info> {
         &self,
         deduplicated: bool,
         account_infos: &'a [AccountInfo],
-    ) -> &'a [AccountInfo] {
+    ) -> Result<&'a [AccountInfo], ProgramError> {
         let start_offset = self.cpi_accounts_start_offset();
         let end_offset = self.cpi_accounts_end_offset(deduplicated);
-        // TODO: validate len.
-        &account_infos[start_offset..end_offset]
+        
+        if end_offset > account_infos.len() {
+            return Err(ErrorCode::CpiAccountsSliceOutOfBounds.into());
+        }
+        
+        Ok(&account_infos[start_offset..end_offset])
     }
 }
 

programs/compressed-token/program/src/mint_action/processor.rs

@@ -157,7 +157,7 @@ pub fn process_mint_action(
 
     sol_log_compute_units();
 
-    let cpi_accounts = validated_accounts.get_cpi_accounts(queue_indices.deduplicated, accounts);
+    let cpi_accounts = validated_accounts.get_cpi_accounts(queue_indices.deduplicated, accounts)?;
     if let Some(executing) = validated_accounts.executing.as_ref() {
         // Execute CPI to light-system-program
         execute_cpi_invoke(

sdk-libs/compressed-token-sdk/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "light-compressed-token-sdk"
-version = { workspace = true }
+version = "0.1.0"
 edition = { workspace = true }
 
 [features]

sdk-libs/token-client/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "light-token-client"
-version = { workspace = true }
+version = "0.1.0"
 edition = { workspace = true }
 
 [features]