Make TAB-completion behave as SHIFT-TAB in REPL except for ?(x,y) syntax (JuliaLang#43577)

Author: Liozou

stdlib/REPL/src/REPL.jl

@@ -494,15 +494,7 @@ beforecursor(buf::IOBuffer) = String(buf.data[1:buf.ptr-1])
 function complete_line(c::REPLCompletionProvider, s::PromptState)
     partial = beforecursor(s.input_buffer)
     full = LineEdit.input_string(s)
-    ret, range, should_complete = completions(full, lastindex(partial))
-    if !c.modifiers.shift
-        # Filter out methods where all arguments are `Any`
-        filter!(ret) do c
-            isa(c, REPLCompletions.MethodCompletion) || return true
-            sig = Base.unwrap_unionall(c.method.sig)::DataType
-            return !all(T -> T === Any || T === Vararg{Any}, sig.parameters[2:end])
-        end
-    end
+    ret, range, should_complete = completions(full, lastindex(partial), Main, c.modifiers.shift)
     c.modifiers = LineEdit.Modifiers()
     return unique!(map(completion_text, ret)), partial[range], should_complete
 end

stdlib/REPL/src/REPLCompletions.jl

@@ -506,7 +506,7 @@ function complete_methods(ex_org::Expr, context_module::Module=Main)
     return out
 end
 
-function complete_any_methods(ex_org::Expr, callee_module::Module, context_module::Module, moreargs::Bool)
+function complete_any_methods(ex_org::Expr, callee_module::Module, context_module::Module, moreargs::Bool, shift::Bool)
     out = Completion[]
     args_ex, kwargs_ex = try
         complete_methods_args(ex_org.args[2:end], ex_org, context_module, false, false)
@@ -533,6 +533,15 @@ function complete_any_methods(ex_org::Expr, callee_module::Module, context_modul
         end
     end
 
+    if !shift
+        # Filter out methods where all arguments are `Any`
+        filter!(out) do c
+            isa(c, REPLCompletions.MethodCompletion) || return true
+            sig = Base.unwrap_unionall(c.method.sig)::DataType
+            return !all(T -> T === Any || T === Vararg{Any}, sig.parameters[2:end])
+        end
+    end
+
     return out
 end
 
@@ -719,7 +728,7 @@ function project_deps_get_completion_candidates(pkgstarts::String, project_file:
     return Completion[PackageCompletion(name) for name in loading_candidates]
 end
 
-function completions(string::String, pos::Int, context_module::Module=Main)
+function completions(string::String, pos::Int, context_module::Module=Main, shift::Bool=true)
     # First parse everything up to the current position
     partial = string[1:pos]
     inc_tag = Base.incomplete_tag(Meta.parse(partial, raise=false, depwarn=false))
@@ -750,7 +759,7 @@ function completions(string::String, pos::Int, context_module::Module=Main)
         end
         ex_org = Meta.parse(callstr, raise=false, depwarn=false)
         if isa(ex_org, Expr)
-            return complete_any_methods(ex_org, callee_module::Module, context_module, moreargs), (0:length(rexm.captures[1])+1) .+ rexm.offset, false
+            return complete_any_methods(ex_org, callee_module::Module, context_module, moreargs, shift), (0:length(rexm.captures[1])+1) .+ rexm.offset, false
         end
     end
 

stdlib/REPL/test/replcompletions.jl

@@ -127,6 +127,7 @@ test_scomplete(s) =  map_completion_text(@inferred(shell_completions(s, lastinde
 test_bslashcomplete(s) =  map_completion_text(@inferred(bslash_completions(s, lastindex(s)))[2])
 test_complete_context(s, m) =  map_completion_text(@inferred(completions(s,lastindex(s), m)))
 test_complete_foo(s) = test_complete_context(s, Main.CompletionFoo)
+test_complete_noshift(s) = map_completion_text(@inferred(completions(s, lastindex(s), Main, false)))
 
 module M32377 end
 test_complete_32377(s) = map_completion_text(completions(s,lastindex(s), M32377))
@@ -567,6 +568,33 @@ let s = "CompletionFoo.?('c'"
     @test  any(str->occursin("test9(x::Char, i::Int", str), c)
 end
 
+let s = "CompletionFoo.?(false, \"a\", 3, "
+    c, r, res = test_complete(s)
+    @test !res
+    @test length(c) == 1
+    @test occursin("test(args...)", c[1])
+end
+
+let s = "CompletionFoo.?(false, \"a\", 3, "
+    c, r, res = test_complete_noshift(s)
+    @test !res
+    @test isempty(c)
+end
+
+let s = "CompletionFoo.?()"
+    c, r, res = test_complete(s)
+    @test !res
+    @test any(str->occursin("foo()", str), c)
+    @test any(str->occursin("kwtest(;", str), c)
+    @test any(str->occursin("test(args...)", str), c)
+end
+
+let s = "CompletionFoo.?()"
+    c, r, res = test_complete_noshift(s)
+    @test !res
+    @test isempty(c)
+end
+
 #################################################################
 
 # Test of inference based getfield completion