Skip to content

Commit 5be036d

Browse files
Treehugger Robotandroid-build-merge-worker-robot
authored andcommitted
Merge "LatinIME: Fix Implicit PendingIntent Vulnerability" into main am: 1b3568f am: fee42b3
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/3019664 Change-Id: Ic393ce61210263a49384bbdd232a49e1ef10ae13 Signed-off-by: Automerger Merge Worker <[email protected]>
2 parents ba40b2f + fee42b3 commit 5be036d

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

java/src/com/android/inputmethod/dictionarypack/DictionaryService.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,14 @@ private static void checkTimeAndMaybeSetupUpdateAlarm(final Context context) {
229229
final long now = System.currentTimeMillis();
230230
final long alarmTime = now + new Random().nextInt(MAX_ALARM_DELAY_MILLIS);
231231
final Intent updateIntent = new Intent(DictionaryPackConstants.UPDATE_NOW_INTENT_ACTION);
232+
// Set the package name to ensure the PendingIntent is only delivered to trusted components
233+
updateIntent.setPackage(context.getPackageName());
234+
int pendingIntentFlags = PendingIntent.FLAG_CANCEL_CURRENT;
235+
if (android.os.Build.VERSION.SDK_INT >= 23) {
236+
pendingIntentFlags |= PendingIntent.FLAG_IMMUTABLE;
237+
}
232238
final PendingIntent pendingIntent = PendingIntent.getBroadcast(context, 0,
233-
updateIntent, PendingIntent.FLAG_CANCEL_CURRENT);
239+
updateIntent, pendingIntentFlags);
234240

235241
// We set the alarm in the type that doesn't forcefully wake the device
236242
// from sleep, but fires the next time the device actually wakes for any

0 commit comments

Comments
 (0)