Merge pull request #124 from LinioIT/feat/SCP-2513-enable-null-national-registration-number

[SCP-2513] enable null national registration number in SDK

Author: yinosanchez

src/Factory/Xml/Order/OrderFactory.php

@@ -31,7 +31,6 @@ class OrderFactory
         'AddressUpdatedAt',
         'AddressBilling',
         'AddressShipping',
-        'NationalRegistrationNumber',
         'PromisedShippingTime',
         'ItemsCount',
         'ExtraAttributes',
@@ -60,6 +59,8 @@ public static function make(SimpleXMLElement $element): Order
         $dateTime = DateTimeImmutable::createFromFormat('Y-m-d H:i:s', (string) $element->PromisedShippingTime);
         $promisedShippingTime = !empty($dateTime) ? $dateTime : null;
 
+        $nationalRegistrationNumber = !empty($element->NationalRegistrationNumber) ? (string) $element->NationalRegistrationNumber : null;
+
         $statuses = [];
         foreach ($element->Statuses->Status as $status) {
             array_push($statuses, (string) $status);
@@ -89,7 +90,7 @@ public static function make(SimpleXMLElement $element): Order
             $addressUpdatedAt,
             $addressBilling,
             $addressShipping,
-            (string) $element->NationalRegistrationNumber,
+            $nationalRegistrationNumber,
             (int) $element->ItemsCount,
             $promisedShippingTime,
             (string) $element->ExtraAttributes,

src/Model/Order/Order.php

@@ -146,7 +146,7 @@ public static function fromData(
         ?DateTimeInterface $addressUpdatedAt,
         Address $addressBilling,
         Address $addressShipping,
-        string $nationalRegistrationNumber,
+        ?string $nationalRegistrationNumber,
         int $itemsCount,
         ?DateTimeInterface $promisedShippingTime,
         ?string $extraAttributes,

tests/Unit/Order/OrderTest.php

@@ -265,7 +265,6 @@ public function invalidXmlStructure(): array
             ['AddressUpdatedAt'],
             ['AddressBilling'],
             ['AddressShipping'],
-            ['NationalRegistrationNumber'],
             ['ItemsCount'],
             ['PromisedShippingTime'],
             ['ExtraAttributes'],