Skip to content

Commit 697ed3c

Browse files
committed
retrieve link url from database rather than request url
increases robustness and solve issues with sloppy redirect interpretation across browsers
1 parent 661813b commit 697ed3c

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

app/Http/Controllers/UserController.php

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -183,21 +183,15 @@ public function sortLinks(Request $request)
183183
public function clickNumber(request $request)
184184
{
185185
$link = $request->link;
186-
$query = $request->query();
187186
$linkId = $request->id;
188187

189188
if(empty($link && $linkId))
190189
{
191190
return abort(404);
192191
}
193-
194-
if(!empty($query)) {
195-
$qs = [];
196-
foreach($query as $qk => $qv) { $qs[] = $qk .'='. $qv; }
197-
$link = $link .'?'. implode('&', $qs);
198-
}
199192

200193
Link::where('id', $linkId)->increment('click_number', 1);
194+
$link = Link::select('link')->where('id', $linkId)->get()[0]['link'];
201195

202196
return redirect()->away($link);
203197
}

0 commit comments

Comments
 (0)