Support for http.ClientRequest#setHeader, #getHeader, #removeHeader

[ChrisC]

Am running into a lot of problems using Sepia with Superagent. I've determined that the problem is that methods such as setHeader, getHeader are removed from http.ClientRequest. See the issue and solution as described here for the Nock VCR lib :
nock/nock#41
jherdman/nock@0f4e634

Would it be inadvisable to add something similar to Sepia?

[avik-das]

@ChrisC : I've run into this issue when I was making sure sepia worked with the request library. The discussion you linked to hits the nail on the head. Indeed, the fundamental problem is that the "dummy" request sepia provides does not behave like an http.ClientRequest because it isn't one.

I like the approach nock takes, and it would be great to have that in sepia. The implementation in nock isn't exactly self-contained, so it'll take some work to get a corresponding implementation in sepia.

[gilbert]

I just ran into this issue today. Did you find a workaround, @ChrisC ?

[gilbert]

I fixed the problem by switching to node-replay.

[airportyh]

Also ran into this while trying out sepia - attempting to use it with supertest.

[ajsharp]

Bump

[avik-das]

Hi @ajsharp: I actually haven't committed to this:

I like the approach nock takes, and it would be great to have that in sepia. The implementation in nock isn't exactly self-contained, so it'll take some work to get a corresponding implementation in sepia.

What would be great is a minimal test case, and then I could probably just stub out the necessary methods.

[TamerShlash]

Running to problems when using with supertest as well.