Minor improvemts to bulk copy.

Author: nsarris

Source/ISeriesProvider/DB2iSeriesBulkCopy.AccessClient.cs

@@ -28,7 +28,7 @@ private BulkCopyRowsCopied ProviderSpecificCopyImpl_AccessClient<T>(
 			var columns = descriptor.Columns.Where(c => !c.SkipOnInsert || options.KeepIdentity == true && c.IsIdentity).ToList();
 			var rd = new BulkCopyReader<T>(dataConnection, columns, source);
 			var rc = new BulkCopyRowsCopied();
-			var sqlBuilder = dataConnection.DataProvider.CreateSqlBuilder(dataConnection.MappingSchema, dataOptions);
+			var sqlBuilder = dataConnection.DataProvider.CreateSqlBuilder(table.DataContext.MappingSchema, dataOptions);
 			var tableName = GetTableName(sqlBuilder, options, table);
 
 			var columnNames = columns.Select(x => x.ColumnName);

Source/ISeriesProvider/DB2iSeriesBulkCopy.DB2Connect.cs

@@ -1,7 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Tasks;
 using System.Data;
 using System.Linq;
 using System.Data.Common;
@@ -18,19 +16,18 @@ partial class DB2iSeriesBulkCopy : BasicBulkCopy
 		//Copied from DB2BulkCopy
 		private static BulkCopyRowsCopied ProviderSpecificCopyImpl_DB2<T>(
 		ITable<T> table,
-		DataOptions dataOptions,
+		BulkCopyOptions options,
 		IEnumerable<T> source,
 		DataConnection dataConnection,
 		DbConnection connection,
 		DB2.DB2ProviderAdapter.BulkCopyAdapter bulkCopy,
 		Action<DataConnection, Func<string>, Func<int>> traceAction)
 		{
-			var options = dataOptions.BulkCopyOptions;
-			var descriptor = dataConnection.MappingSchema.GetEntityDescriptor(typeof(T));
+			var descriptor = table.DataContext.MappingSchema.GetEntityDescriptor(typeof(T), dataConnection.Options.ConnectionOptions.OnEntityDescriptorCreated);
 			var columns = descriptor.Columns.Where(c => !c.SkipOnInsert || options.KeepIdentity == true && c.IsIdentity).ToList();
 			var rd = new BulkCopyReader<T>(dataConnection, columns, source);
 			var rc = new BulkCopyRowsCopied();
-			var sqlBuilder = dataConnection.DataProvider.CreateSqlBuilder(dataConnection.MappingSchema, dataOptions);
+			var sqlBuilder = dataConnection.DataProvider.CreateSqlBuilder(table.DataContext.MappingSchema, dataConnection.Options);
 			var tableName = GetTableName(sqlBuilder, options, table);
 
 			var bcOptions = DB2BulkCopyOptions.Default;
@@ -47,7 +44,7 @@ private static BulkCopyRowsCopied ProviderSpecificCopyImpl_DB2<T>(
 				{
 					bc.NotifyAfter = notifyAfter;
 
-					bc.DB2RowsCopied += (sender, args) =>
+					bc.DB2RowsCopied += (_, args) =>
 					{
 						rc.RowsCopied = args.RowsCopied;
 						options.RowsCopiedCallback(rc);

Source/ISeriesProvider/DB2iSeriesBulkCopy.cs

@@ -11,6 +11,17 @@ partial class DB2iSeriesBulkCopy : BasicBulkCopy
 	{
 		const int MAX_ALLOWABLE_MULTIPLE_ROWS_BATCH_SIZE = 100;
 
+		/// <remarks>
+		/// Settings based on https://www.ibm.com/docs/en/i/7.3?topic=reference-sql-limits
+		/// We subtract 1 here to be safe since some ADO providers use parameter for command itself.
+		/// </remarks>
+		protected override int MaxParameters => 1999;
+		/// <remarks>
+		/// Setting based on https://www.ibm.com/docs/en/i/7.3?topic=reference-sql-limits
+		/// Max is actually 2MIB, but we keep a lower number here to avoid the cost of huge statements.
+		/// </remarks>
+		protected override int MaxSqlLength => 327670;
+
 		private readonly DB2iSeriesDataProvider dataProvider;
 		private readonly DB2iSeriesSqlProviderFlags dB2ISeriesSqlProviderFlags;
 
@@ -33,7 +44,7 @@ protected override BulkCopyRowsCopied ProviderSpecificCopy<T>(
 					if (dataProvider.TryGetProviderConnection(dataConnection, out var connection))
 						return ProviderSpecificCopyImpl_DB2(
 							table,
-							options,
+							options.BulkCopyOptions,
 							source,
 							dataConnection,
 							connection,
@@ -71,7 +82,7 @@ protected override Task<BulkCopyRowsCopied> ProviderSpecificCopyAsync<T>(ITable<
 						// call the synchronous provider-specific implementation as provider doesn't support async
 						return Task.FromResult(ProviderSpecificCopyImpl_DB2(
 							table,
-							options,
+							options.BulkCopyOptions,
 							source,
 							dataConnection,
 							connection,
@@ -115,7 +126,7 @@ protected override async Task<BulkCopyRowsCopied> ProviderSpecificCopyAsync<T>(I
 							// call the synchronous provider-specific implementation as provider doesn't support async
 							return ProviderSpecificCopyImpl_DB2(
 								table,
-								options,
+								options.BulkCopyOptions,
 								AsyncToSyncEnumerable(enumerator),
 								dataConnection,
 								connection,