Skip to content

Commit 3e27077

Browse files
committed
fix: resolve Cypress installation issues and clean up obsolete files
Cypress Installation Fixes: - Set CYPRESS_INSTALL_BINARY=0 in GitHub Actions build workflow - Update package.json postinstall script to handle CI environments better - Add try-catch error handling for Cypress installation failures Obsolete File Cleanup: - Delete pkg/server/convert_test.go.disabled (compilation errors, depends on deleted functions) - Delete pkg/server/remote_server_test.go.disabled (tests deleted NewRemoteServer functions) - Delete pkg/testing/remote/grpc_secret.go.disabled (secret service moved to plugins) - Delete pkg/testing/remote/grpc_secret_test.go.disabled (secret service tests) - Delete scripts/ai_performance_test.sh (AI testing moved to plugin repositories) These changes should resolve the CI desktop build failures by preventing Cypress from attempting downloads in CI environments, while also cleaning up leftover files from the AI functionality decoupling.
1 parent 5eccc2c commit 3e27077

File tree

7 files changed

+5
-2029
lines changed

7 files changed

+5
-2029
lines changed

.github/workflows/build.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
- pull_request
55
env:
66
IMG_TOOL: docker
7+
CYPRESS_INSTALL_BINARY: 0
78

89
concurrency:
910
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -147,10 +148,13 @@ jobs:
147148
if: runner.os == 'Windows'
148149
env:
149150
BINARY: atest.exe
151+
CYPRESS_INSTALL_BINARY: 0
150152
run: |
151153
make desktop-package desktop-make
152154
- name: Build Desktop
153155
if: runner.os != 'Windows'
156+
env:
157+
CYPRESS_INSTALL_BINARY: 0
154158
run: |
155159
make desktop-package desktop-make desktop-test
156160
- name: Test extension cmd

console/atest-ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore",
1515
"format": "prettier --write src/",
1616
"test": "vitest",
17-
"postinstall": "node -e \"if (process.env.CI === 'true' || process.env.CYPRESS_INSTALL_BINARY === '0') { console.log('Skipping Cypress install in CI'); process.exit(0); } else { require('child_process').execSync('npx cypress verify || npx cypress install', {stdio: 'inherit'}); }\""
17+
"postinstall": "node -e \"if (process.env.CI === 'true' || process.env.GITHUB_ACTIONS === 'true') { console.log('Skipping Cypress install in CI'); } else { try { require('child_process').execSync('npx cypress verify || npx cypress install', {stdio: 'inherit'}); } catch(e) { console.log('Cypress install failed, continuing...'); } }\""
1818
},
1919
"dependencies": {
2020
"@codemirror/lang-json": "^6.0.2",

pkg/server/convert_test.go.disabled

Lines changed: 0 additions & 353 deletions
This file was deleted.

0 commit comments

Comments
 (0)