add unit tests

Author: LinuxSuRen

cmd/function.go

@@ -18,6 +18,7 @@ package cmd
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"go/ast"
 	"go/doc"
@@ -60,7 +61,7 @@ func (o *funcPrinterOption) runE(cmd *cobra.Command, args []string) (err error)
 			return
 		}
 
-		if err = tpl.Validate(); err != nil {
+		if err = errors.Join(err, tpl.Validate(), tpl.ConflictWith(render.FuncMap())); err != nil {
 			return
 		}
 	}

cmd/function_test.go

@@ -29,6 +29,7 @@ func TestCreateFunctionCommand(t *testing.T) {
 	tests := []struct {
 		name   string
 		args   []string
+		hasErr bool
 		verify func(t *testing.T, output string)
 	}{{
 		name: "normal",
@@ -61,6 +62,13 @@ func TestCreateFunctionCommand(t *testing.T) {
 			assert.Equal(t, `{{generateJSONString "name"}}
 `, output)
 		},
+	}, {
+		name:   "verify template functions with error",
+		args:   []string{"func", "--extension-file", "testdata/function-with-conflicts.yaml"},
+		hasErr: true,
+		verify: func(t *testing.T, output string) {
+			assert.Contains(t, output, "conflict with existing function")
+		},
 	}}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -69,10 +77,15 @@ func TestCreateFunctionCommand(t *testing.T) {
 
 			buf := new(bytes.Buffer)
 			c.SetOut(buf)
+			c.SetErr(buf)
 			c.SetArgs(tt.args)
 
 			err := c.Execute()
-			assert.NoError(t, err)
+			if tt.hasErr {
+				assert.Error(t, err)
+			} else {
+				assert.NoError(t, err)
+			}
 
 			if tt.verify != nil {
 				tt.verify(t, buf.String())

cmd/testdata/function-with-conflicts.yaml

@@ -0,0 +1,4 @@
+items:
+  - name: randEnum
+    render: |
+      {{ randInt 18 60 }}

pkg/render/testdata/function-with-conflicts.yaml

@@ -0,0 +1,4 @@
+items:
+  - name: randEnum
+    render: |
+      {{ randInt 18 60 }}

pkg/render/user_defined.go

@@ -18,6 +18,7 @@ package render
 import (
 	"errors"
 	"os"
+	"text/template"
 
 	"gopkg.in/yaml.v3"
 )
@@ -39,6 +40,16 @@ func (t *UserDefinedTemplates) Validate() (err error) {
 	return
 }
 
+func (t *UserDefinedTemplates) ConflictWith(funcMap template.FuncMap) (conflict error) {
+	for _, item := range t.Items {
+		if _, ok := funcMap[item.Name]; ok {
+			conflict = errors.New("conflict with existing function: " + item.Name)
+			break
+		}
+	}
+	return
+}
+
 func ParseUserDefinedTemplates(data []byte) (templates *UserDefinedTemplates, err error) {
 	templates = &UserDefinedTemplates{}
 	err = yaml.Unmarshal(data, templates)

pkg/render/user_defined_test.go

@@ -28,4 +28,10 @@ func TestUserDefinedTemplates(t *testing.T) {
 	assert.NotNil(t, tpl)
 	err = tpl.Validate()
 	assert.NoError(t, err)
+	assert.NoError(t, tpl.ConflictWith(render.FuncMap()))
+
+	tpl, err = render.ParseUserDefinedTemplatesFromFile("testdata/function-with-conflicts.yaml")
+	assert.NoError(t, err)
+	assert.NoError(t, tpl.Validate())
+	assert.Error(t, tpl.ConflictWith(render.FuncMap()))
 }