Skip to content

Commit b572c78

Browse files
authored
fix: Improve error reporting for Query in fileLoader and nonLoader. (#702)
1 parent 6675436 commit b572c78

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

pkg/testing/loader_file.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package testing
1818
import (
1919
"bytes"
2020
"encoding/json"
21+
"errors"
2122
"fmt"
2223
"io"
2324
"net/http"
@@ -516,8 +517,11 @@ func (l *fileLoader) Close() {
516517
}
517518

518519
func (l *fileLoader) Query(query map[string]string) (result DataResult, err error) {
519-
result.Pairs = map[string]string{
520-
"message": "not support",
521-
}
520+
err = errors.New("Query functionality is not yet implemented for fileLoader")
521+
return
522+
}
523+
524+
func (l *fileLoader) GetRoundTripper(name string) (roundTripper http.RoundTripper, err error) {
525+
err = fmt.Errorf("not support")
522526
return
523527
}

pkg/testing/loader_non.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ limitations under the License.
1515
*/
1616
package testing
1717

18+
import (
19+
"errors"
20+
)
21+
1822
// nonLoader is an empty implement for avoid too many nil check
1923
type nonLoader struct{}
2024

@@ -151,5 +155,6 @@ func (l *nonLoader) Close() {
151155
}
152156

153157
func (l *nonLoader) Query(query map[string]string) (result DataResult, err error) {
158+
err = errors.New("Query functionality is not implemented for nonLoader")
154159
return
155160
}

0 commit comments

Comments
 (0)