Skip to content

Commit d40a2f7

Browse files
authored
fix: desktop build error (#849)
* fix: desktop build error * remove install dir setting part --------- Co-authored-by: rick <[email protected]>
1 parent f0d3b75 commit d40a2f7

File tree

3 files changed

+19
-67
lines changed

3 files changed

+19
-67
lines changed

console/atest-desktop/forge.config.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -52,33 +52,6 @@ module.exports = {
5252
"enabled": true,
5353
"chooseDirectory": true
5454
},
55-
beforeCreate: (msiCreator) => {
56-
// Add installation directory to system PATH
57-
msiCreator.wixTemplate = msiCreator.wixTemplate.replace(
58-
'</Product>',
59-
` <Property Id="ARPINSTALLLOCATION" Value="[INSTALLDIR]" />
60-
<CustomAction Id="AddToPath" Property="PATH" Value="[INSTALLDIR]" Execute="immediate" />
61-
<CustomAction Id="RemoveFromPath" Property="PATH" Value="[INSTALLDIR]" Execute="immediate" />
62-
63-
<InstallExecuteSequence>
64-
<Custom Action="AddToPath" After="InstallFiles">NOT Installed</Custom>
65-
<Custom Action="RemoveFromPath" Before="RemoveFiles">REMOVE="ALL"</Custom>
66-
</InstallExecuteSequence>
67-
68-
<Component Id="PathComponent" Guid="*" Directory="INSTALLDIR">
69-
<Environment Id="PATH" Name="PATH" Value="[INSTALLDIR]" Permanent="no" Part="last" Action="set" System="yes" />
70-
</Component>
71-
72-
</Product>`
73-
);
74-
75-
// Ensure INSTALLDIR is properly defined in the existing ProgramFilesFolder
76-
msiCreator.wixTemplate = msiCreator.wixTemplate.replace(
77-
'<Directory Id="ProgramFilesFolder">',
78-
`<Directory Id="ProgramFilesFolder">
79-
<Directory Id="INSTALLDIR" Name="API Testing" />`
80-
);
81-
}
8255
}
8356
}
8457
],

console/atest-desktop/package-lock.json

Lines changed: 18 additions & 39 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

console/atest-desktop/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"publish": "electron-forge publish"
1212
},
1313
"engines": {
14-
"node": "22.12.0"
14+
"node": ">=22.12.0"
1515
},
1616
"author": "linuxsuren",
1717
"license": "ISC",

0 commit comments

Comments
 (0)