-
Notifications
You must be signed in to change notification settings - Fork 61
improving UI of TestSuite #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@LinuxSuRen please Review the PR |
LinuxSuRen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking if you could try to put the CSS into a css file. So other page could reuse it.
ok |
@LinuxSuRen
|
|
How about improving the CSS file structure first? Then we could add content in the later PRs. |
ok agreed |
Of course. Putting all CSS into each file is not a good practice. It's hard to maintain and keep the same style from all pages. |
|
@LinuxSuRen Should I Close this PR because adding Tailwind will take little time and wont be possible in this PR Or Should i keep this PR for merging Now |
|
I prefer to keep this PR open. I will spend more time reviewing it. Hopefully we could keep the all pages as consistant style, and improve the looks at the meaning time. |
| .delete-button { | ||
| box-shadow: 0 4px 12px rgba(245, 108, 108, 0.3); | ||
| } | ||
| .delete-button:hover { | ||
| box-shadow: 0 6px 20px rgba(245, 108, 108, 0.4); | ||
| } | ||
| .create-dialog :deep(.el-dialog) { | ||
| border-radius: 16px; | ||
| overflow: hidden; | ||
| } | ||
| .create-dialog :deep(.el-dialog__header) { | ||
| color: white; | ||
| padding: 20px 24px; | ||
| } | ||
| .dialog-form { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parts could be a common style. For example, many pages contain delete button. We can definitely reuse button styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure i will keep the code for used in later changes in project
|
Current component framework supports the theme. See also https://element-plus.org/en-US/guide/theming.html |
|
Below is a website that show how to customize the web page. |
|
Will take reference for it for further development of UI |
|
Now we can change the theme. See also #715. Users can choose the theme once a new theme is added to the following repository. https://github.com/LinuxSuRen/atest-ext-data-swagger/tree/master/data/theme So, I'm thinking if you could abstract your color scheme and other improvement as a new theme? |
ok working on it |
|
@LinuxSuRen Closing this PR because i am doing chnages with GOOD UI in next PR with Tailwind |



Screencast.from.2025-06-13.17-10-31.webm
What type of PR is this?
Imroving UI
What this PR does / why we need it:
makes UI smooth and better
Which issue(s) this PR fixes: