Skip to content

Conversation

@Aditya-132
Copy link
Contributor

@Aditya-132 Aditya-132 commented Jun 13, 2025

Screencast.from.2025-06-13.17-10-31.webm

We highly recommend you read the contributor's documentation before starting the review process especially since this is your first contribution to this project.

It was updated on 2024/5/27

What type of PR is this?
Imroving UI

What this PR does / why we need it:
makes UI smooth and better
Which issue(s) this PR fixes:

@sonarqubecloud
Copy link

@Aditya-132
Copy link
Contributor Author

@LinuxSuRen please Review the PR

Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking if you could try to put the CSS into a css file. So other page could reuse it.

@Aditya-132
Copy link
Contributor Author

I'm thinking if you could try to put the CSS into a css file. So other page could reuse it.

ok

@Aditya-132
Copy link
Contributor Author

Aditya-132 commented Jun 13, 2025

I'm thinking if you could try to put the CSS into a css file. So other page could reuse it.

@LinuxSuRen
their is problem in creating different CSS file

  1. there will duplicates of classes present in every file
  2. there will issue as there is already is main.css and if there will be ultiple css files it will be very complex to see which file gets higher priority

@LinuxSuRen
Copy link
Owner

How about improving the CSS file structure first? Then we could add content in the later PRs.

@Aditya-132
Copy link
Contributor Author

How about improving the CSS file structure first? Then we could add content in the later PRs.

ok agreed
@LinuxSuRen
it just my opinion that using CSS libraries like Tailwind would be better for future

@LinuxSuRen
Copy link
Owner

using CSS libraries like Tailwind would be better for future

Of course. Putting all CSS into each file is not a good practice. It's hard to maintain and keep the same style from all pages.

@Aditya-132
Copy link
Contributor Author

Aditya-132 commented Jun 13, 2025

@LinuxSuRen Should I Close this PR because adding Tailwind will take little time and wont be possible in this PR Or Should i keep this PR for merging Now

@LinuxSuRen
Copy link
Owner

I prefer to keep this PR open. I will spend more time reviewing it. Hopefully we could keep the all pages as consistant style, and improve the looks at the meaning time.

Comment on lines +935 to +954
.delete-button {
box-shadow: 0 4px 12px rgba(245, 108, 108, 0.3);
}
.delete-button:hover {
box-shadow: 0 6px 20px rgba(245, 108, 108, 0.4);
}
.create-dialog :deep(.el-dialog) {
border-radius: 16px;
overflow: hidden;
}
.create-dialog :deep(.el-dialog__header) {
color: white;
padding: 20px 24px;
}
.dialog-form {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parts could be a common style. For example, many pages contain delete button. We can definitely reuse button styles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure i will keep the code for used in later changes in project

@LinuxSuRen LinuxSuRen added the ospp 开源之夏 https://summer-ospp.ac.cn/ label Jun 14, 2025
@LinuxSuRen
Copy link
Owner

Current component framework supports the theme. See also https://element-plus.org/en-US/guide/theming.html

@LinuxSuRen
Copy link
Owner

Below is a website that show how to customize the web page.
https://tweakcn.com/

@Aditya-132
Copy link
Contributor Author

Will take reference for it for further development of UI

@LinuxSuRen
Copy link
Owner

Now we can change the theme. See also #715. Users can choose the theme once a new theme is added to the following repository.

https://github.com/LinuxSuRen/atest-ext-data-swagger/tree/master/data/theme

So, I'm thinking if you could abstract your color scheme and other improvement as a new theme?

@Aditya-132
Copy link
Contributor Author

Now we can change the theme. See also #715. Users can choose the theme once a new theme is added to the following repository.

https://github.com/LinuxSuRen/atest-ext-data-swagger/tree/master/data/theme

So, I'm thinking if you could abstract your color scheme and other improvement as a new theme?

ok working on it

@Aditya-132 Aditya-132 closed this Jun 26, 2025
@Aditya-132
Copy link
Contributor Author

@LinuxSuRen Closing this PR because i am doing chnages with GOOD UI in next PR with Tailwind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ospp 开源之夏 https://summer-ospp.ac.cn/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants