fix: satisfy golangci checks

Author: KariHall619

.github/workflows/ci.yml

@@ -56,11 +56,13 @@ jobs:
     - name: Build frontend assets
       run: make build-frontend
 
+    - name: Install golangci-lint v2
+      run: |
+        curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v2.4.0
+        echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+
     - name: Lint
-      uses: golangci/golangci-lint-action@v4
-      with:
-        version: v2.4.0
-        args: --timeout=10m
+      run: golangci-lint run --timeout=10m
 
     - name: Security check with gosec
       run: |

.github/workflows/verify.yml

@@ -21,6 +21,7 @@ jobs:
       - name: Install golangci-lint v2
         run: |
           curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v2.4.0
+          echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
 
       - name: Run verification task
         run: make verify

pkg/ai/engine.go

@@ -99,8 +99,7 @@ type aiEngine struct {
 	manager   *Manager
 }
 
-// NewEngine creates a new AI engine based on configuration
-
+// NewEngine creates a new AI engine based on configuration.
 func NewEngine(cfg config.AIConfig) (Engine, error) {
 	manager, err := NewAIManager(cfg)
 	if err != nil {
@@ -156,6 +155,7 @@ func newEngineFromManager(manager *Manager, cfg config.AIConfig) (Engine, error)
 	}, nil
 }
 
+// NewEngineWithManager constructs an Engine using a pre-configured Manager.
 func NewEngineWithManager(manager *Manager, cfg config.AIConfig) (Engine, error) {
 	if manager == nil {
 		return nil, fmt.Errorf("manager cannot be nil")

pkg/ai/generator.go

@@ -676,6 +676,7 @@ func (g *SQLGenerator) getOrCreateRuntimeClient(options *GenerateOptions) (inter
 	return client, false, nil
 }
 
+// Close releases all cached runtime clients held by the generator.
 func (g *SQLGenerator) Close() {
 	g.runtimeMu.Lock()
 	defer g.runtimeMu.Unlock()

pkg/ai/providers/openai/client.go

@@ -25,6 +25,7 @@ import (
 	"time"
 
 	"github.com/linuxsuren/atest-ext-ai/pkg/interfaces"
+	"github.com/linuxsuren/atest-ext-ai/pkg/logging"
 	"github.com/tmc/langchaingo/llms"
 	"github.com/tmc/langchaingo/llms/openai"
 )
@@ -289,7 +290,11 @@ func (c *Client) HealthCheck(ctx context.Context) (*interfaces.HealthStatus, err
 		status.Errors = []string{err.Error()}
 		return status, nil
 	}
-	defer resp.Body.Close()
+	defer func() {
+		if cerr := resp.Body.Close(); cerr != nil {
+			logging.Logger.Warn("Failed to close OpenAI health check response body", "error", cerr)
+		}
+	}()
 
 	if resp.StatusCode >= 200 && resp.StatusCode < 300 {
 		status.Healthy = true

pkg/ai/providers/openai/client_test.go

@@ -34,7 +34,7 @@ func TestHealthCheckSuccess(t *testing.T) {
 }
 
 func TestHealthCheckFailure(t *testing.T) {
-	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(http.StatusServiceUnavailable)
 	}))
 	t.Cleanup(server.Close)

pkg/plugin/service.go

@@ -1258,7 +1258,7 @@ func (s *AIPluginService) handleTestConnection(ctx context.Context, req *server.
 }
 
 // handleUpdateConfig updates the configuration for a provider
-func (s *AIPluginService) handleUpdateConfig(ctx context.Context, req *server.DataQuery) (*server.DataQueryResult, error) {
+func (s *AIPluginService) handleUpdateConfig(_ context.Context, req *server.DataQuery) (*server.DataQueryResult, error) {
 	logging.Logger.Debug("Handling update config request", "sql_length", len(req.Sql))
 
 	// Parse update request from SQL field