increase the history record limit to 1000 (#19)

add a flag to set the limit as well

Co-authored-by: rick <[email protected]>

Author: LinuxSuRen

cmd/root.go

@@ -32,6 +32,7 @@ func NewRootCommand() (c *cobra.Command) {
 		RunE:  opt.runE,
 	}
 	opt.AddFlags(c.Flags())
+	c.Flags().IntVarP(&opt.historyLimit, "history-limit", "", 1000, "History record items count limit")
 	c.Flags().BoolVarP(&opt.version, "version", "", false, "Print the version then exit")
 	return
 }
@@ -42,12 +43,13 @@ func (o *option) runE(c *cobra.Command, args []string) (err error) {
 		c.Println(version.GetDate())
 		return
 	}
-	remoteServer := pkg.NewRemoteServer()
+	remoteServer := pkg.NewRemoteServer(o.historyLimit)
 	err = ext.CreateRunner(o.Extension, c, remoteServer)
 	return
 }
 
 type option struct {
 	*ext.Extension
-	version bool
+	historyLimit int
+	version      bool
 }

pkg/server.go

@@ -19,6 +19,12 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"log"
+	"os"
+	"path/filepath"
+	"strconv"
+	"strings"
+
 	"github.com/linuxsuren/api-testing/pkg/extension"
 	"github.com/linuxsuren/api-testing/pkg/server"
 	"github.com/linuxsuren/api-testing/pkg/testing/remote"
@@ -29,20 +35,18 @@ import (
 	"gorm.io/driver/sqlite"
 	"gorm.io/gorm"
 	"gorm.io/gorm/logger"
-	"log"
-	"os"
-	"path/filepath"
-	"strconv"
-	"strings"
 )
 
 type dbserver struct {
 	remote.UnimplementedLoaderServer
+	defaultHistoryLimit int
 }
 
 // NewRemoteServer creates a remote server instance
-func NewRemoteServer() (s remote.LoaderServer) {
-	s = &dbserver{}
+func NewRemoteServer(defaultHistoryLimit int) (s remote.LoaderServer) {
+	s = &dbserver{
+		defaultHistoryLimit: defaultHistoryLimit,
+	}
 	return
 }
 
@@ -242,10 +246,12 @@ func (s *dbserver) CreateTestCaseHistory(ctx context.Context, historyTestResult
 	}
 
 	store := remote.GetStoreFromContext(ctx)
-	historyLimit := 10
+	historyLimit := s.defaultHistoryLimit
 	if v, ok := store.Properties["historyLimit"]; ok {
 		if parsedHistoryLimit, parseErr := strconv.Atoi(v); parseErr == nil {
 			historyLimit = parsedHistoryLimit
+		} else {
+			log.Printf("failed to parse history limit: %v\n", parseErr)
 		}
 	}
 
@@ -255,15 +261,15 @@ func (s *dbserver) CreateTestCaseHistory(ctx context.Context, historyTestResult
 	if count >= int64(historyLimit) {
 		var oldestRecord HistoryTestResult
 		if err = db.Order("create_time").First(&oldestRecord).Error; err != nil {
-			fmt.Printf("Error find oldest record: %v\n", err)
+			log.Printf("Error find oldest record: %v\n", err)
 			return
 		}
 
 		if err = db.Delete(&oldestRecord).Error; err != nil {
-			fmt.Printf("Error delete oldest record: %v\n", err)
+			log.Printf("Error delete oldest record: %v\n", err)
 			return
 		}
-		fmt.Printf("Existing count: %d, limit: %d\nmaximum number of entries reached.\n", count, historyLimit)
+		log.Printf("Existing count: %d, limit: %d\nmaximum number of entries reached.\n", count, historyLimit)
 	}
 
 	db.Create(ConvertToDBHistoryTestResult(historyTestResult))

pkg/server_test.go

@@ -18,18 +18,19 @@ package pkg
 import (
 	"context"
 	"fmt"
+	"os"
+	"testing"
+	"time"
+
 	"github.com/linuxsuren/api-testing/pkg/server"
 	atest "github.com/linuxsuren/api-testing/pkg/testing"
 	"github.com/linuxsuren/api-testing/pkg/testing/remote"
 	"github.com/stretchr/testify/assert"
 	"google.golang.org/protobuf/types/known/timestamppb"
-	"os"
-	"testing"
-	"time"
 )
 
 func TestNewRemoteServer(t *testing.T) {
-	remoteServer := NewRemoteServer()
+	remoteServer := NewRemoteServer(10)
 	assert.NotNil(t, remoteServer)
 	defaultCtx := context.Background()
 
@@ -120,7 +121,7 @@ func TestNewRemoteServer(t *testing.T) {
 	})
 
 	t.Run("invalid orm driver", func(t *testing.T) {
-		remoteServer := NewRemoteServer()
+		remoteServer := NewRemoteServer(10)
 		assert.NotNil(t, remoteServer)
 		defaultCtx := remote.WithIncomingStoreContext(context.TODO(), &atest.Store{
 			Properties: map[string]string{
@@ -132,7 +133,7 @@ func TestNewRemoteServer(t *testing.T) {
 	})
 
 	t.Run("invalid mysql config", func(t *testing.T) {
-		remoteServer := NewRemoteServer()
+		remoteServer := NewRemoteServer(10)
 		assert.NotNil(t, remoteServer)
 		defaultCtx := remote.WithIncomingStoreContext(context.TODO(), &atest.Store{
 			Properties: map[string]string{
@@ -144,7 +145,7 @@ func TestNewRemoteServer(t *testing.T) {
 	})
 
 	t.Run("invalid postgres config", func(t *testing.T) {
-		remoteServer := NewRemoteServer()
+		remoteServer := NewRemoteServer(10)
 		assert.NotNil(t, remoteServer)
 		defaultCtx := remote.WithIncomingStoreContext(context.TODO(), &atest.Store{
 			Properties: map[string]string{
@@ -158,7 +159,7 @@ func TestNewRemoteServer(t *testing.T) {
 }
 
 func TestSQLite(t *testing.T) {
-	remoteServer := NewRemoteServer()
+	remoteServer := NewRemoteServer(10)
 	assert.NotNil(t, remoteServer)
 	defaultCtx := remote.WithIncomingStoreContext(context.TODO(), &atest.Store{
 		Properties: map[string]string{