Add syscall support for the generic installation (#261)

Author: LinuxSuRen

pkg/os/generic/common.go

@@ -3,7 +3,9 @@ package generic
 import (
 	"fmt"
 	"github.com/linuxsuren/http-downloader/pkg/exec"
+	"os"
 	"runtime"
+	"syscall"
 )
 
 // CommonInstaller is the installer of a common bash
@@ -16,8 +18,27 @@ type CommonInstaller struct {
 
 // CmdWithArgs is a command and with args
 type CmdWithArgs struct {
-	Cmd  string   `yaml:"cmd"`
-	Args []string `yaml:"args"`
+	Cmd        string   `yaml:"cmd"`
+	Args       []string `yaml:"args"`
+	SystemCall bool     `yaml:"systemCall"`
+}
+
+// Run runs the current command
+func (c CmdWithArgs) Run() (err error) {
+	fmt.Println(c.SystemCall)
+	if c.SystemCall {
+		var targetBinary string
+		if targetBinary, err = exec.LookPath(c.Cmd); err != nil {
+			err = fmt.Errorf("cannot find %s", c.Cmd)
+		} else {
+			sysCallArgs := []string{c.Cmd}
+			sysCallArgs = append(sysCallArgs, c.Args...)
+			err = syscall.Exec(targetBinary, sysCallArgs, os.Environ())
+		}
+	} else {
+		err = exec.RunCommand(c.Cmd, c.Args...)
+	}
+	return
 }
 
 // Available check if support current platform
@@ -28,13 +49,13 @@ func (d *CommonInstaller) Available() (ok bool) {
 
 // Install installs the target package
 func (d *CommonInstaller) Install() (err error) {
-	err = exec.RunCommand(d.InstallCmd.Cmd, d.InstallCmd.Args...)
+	err = d.InstallCmd.Run()
 	return
 }
 
-// Uninstall uninstalls the Conntrack
+// Uninstall uninstalls the target package
 func (d *CommonInstaller) Uninstall() (err error) {
-	err = exec.RunCommand(d.UninstallCmd.Cmd, d.UninstallCmd.Args...)
+	err = d.UninstallCmd.Run()
 	return
 }
 
@@ -44,13 +65,13 @@ func (d *CommonInstaller) WaitForStart() (ok bool, err error) {
 	return
 }
 
-// Start starts the Conntrack service
+// Start starts the desired service
 func (d *CommonInstaller) Start() error {
 	fmt.Println("not supported yet")
 	return nil
 }
 
-// Stop stops the Conntrack service
+// Stop stops the desired service
 func (d *CommonInstaller) Stop() error {
 	fmt.Println("not supported yet")
 	return nil

pkg/os/generic_installer.go

@@ -45,8 +45,9 @@ type genericPackage struct {
 
 // CmdWithArgs is a command with arguments
 type CmdWithArgs struct {
-	Cmd  string   `yaml:"cmd"`
-	Args []string `yaml:"args"`
+	Cmd        string   `yaml:"cmd"`
+	Args       []string `yaml:"args"`
+	SystemCall bool     `yaml:"systemCall"`
 }
 
 func parseGenericPackages(configFile string, genericPackages *genericPackages) (err error) {
@@ -93,12 +94,14 @@ func GenericInstallerRegistry(configFile string, registry core.InstallerRegistry
 				Name: genericPackage.Name,
 				OS:   genericPackage.OS,
 				InstallCmd: generic.CmdWithArgs{
-					Cmd:  genericPackage.InstallCmd.Cmd,
-					Args: genericPackage.InstallCmd.Args,
+					Cmd:        genericPackage.InstallCmd.Cmd,
+					Args:       genericPackage.InstallCmd.Args,
+					SystemCall: genericPackage.InstallCmd.SystemCall,
 				},
 				UninstallCmd: generic.CmdWithArgs{
-					Cmd:  genericPackage.UninstallCmd.Cmd,
-					Args: genericPackage.UninstallCmd.Args,
+					Cmd:        genericPackage.UninstallCmd.Cmd,
+					Args:       genericPackage.UninstallCmd.Args,
+					SystemCall: genericPackage.UninstallCmd.SystemCall,
 				},
 			}
 		}