Fix the potential fetch error (#199)

Author: LinuxSuRen

cmd/install.go

@@ -104,13 +104,15 @@ func (o *installOption) preRunE(cmd *cobra.Command, args []string) (err error) {
 		if o.Category == "" {
 			err = o.downloadOption.preRunE(cmd, args)
 
-			// try to find the real tool name
-			if o.downloadOption.Package.TargetBinary != "" {
-				o.tool = o.downloadOption.Package.TargetBinary
-			} else if o.downloadOption.Package.Binary != "" {
-				o.tool = o.downloadOption.Package.Binary
-			} else {
-				o.tool = o.downloadOption.Package.Repo
+			if o.downloadOption.Package != nil {
+				// try to find the real tool name
+				if o.downloadOption.Package.TargetBinary != "" {
+					o.tool = o.downloadOption.Package.TargetBinary
+				} else if o.downloadOption.Package.Binary != "" {
+					o.tool = o.downloadOption.Package.Binary
+				} else {
+					o.tool = o.downloadOption.Package.Repo
+				}
 			}
 		} else {
 			err = o.downloadOption.fetch()

go.sum

@@ -44,8 +44,6 @@ cloud.google.com/go/storage v1.8.0/go.mod h1:Wv1Oy7z6Yz3DshWRJFhqM/UCfaWIRTdp0RX
 cloud.google.com/go/storage v1.10.0/go.mod h1:FLPqc6j+Ki4BU591ie1oL6qBQGu2Bl/tZ9ullr3+Kg0=
 dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
 github.com/AlecAivazis/survey/v2 v2.2.2/go.mod h1:9FJRdMdDm8rnT+zHVbvQT2RTSTLq0Ttd6q3Vl2fahjk=
-github.com/AlecAivazis/survey/v2 v2.3.1 h1:lzkuHA60pER7L4eYL8qQJor4bUWlJe4V0gqAT19tdOA=
-github.com/AlecAivazis/survey/v2 v2.3.1/go.mod h1:TH2kPCDU3Kqq7pLbnCWwZXDBjnhZtmsCle5EiYDJ2fg=
 github.com/AlecAivazis/survey/v2 v2.3.2 h1:TqTB+aDDCLYhf9/bD2TwSO8u8jDSmMUd2SUVO4gCnU8=
 github.com/AlecAivazis/survey/v2 v2.3.2/go.mod h1:TH2kPCDU3Kqq7pLbnCWwZXDBjnhZtmsCle5EiYDJ2fg=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=

pkg/installer/fetch.go

@@ -35,7 +35,8 @@ func GetConfigDir() (configDir string, err error) {
 }
 
 // FetchLatestRepo fetches the hd-home as the config
-func FetchLatestRepo(provider string, branch string, progress io.Writer) (err error) {
+func FetchLatestRepo(provider string, branch string,
+	progress io.Writer) (err error) {
 	repoAddr, ok := configRepos[provider]
 	if !ok {
 		fmt.Printf("not support '%s', use 'github' instead\n", provider)
@@ -67,21 +68,31 @@ func FetchLatestRepo(provider string, branch string, progress io.Writer) (err er
 					return
 				}
 
-				head, _ := repo.Head()
-
-				// avoid force push from remote
-				if err = wd.Reset(&git.ResetOptions{
-					Commit: head.Hash(),
-					Mode:   git.HardReset,
-				}); err != nil {
-					err = fmt.Errorf("unable to reset to '%s'", head.Hash().String())
+				if err = repo.Fetch(&git.FetchOptions{
+					RemoteName: remoteName,
+					Progress:   progress,
+					Force:      true,
+				}); err != nil && err != git.NoErrAlreadyUpToDate {
+					err = fmt.Errorf("failed to fetch '%s', error: %v", remoteName, err)
 					return
 				}
 
+				head, _ := repo.Head()
+				if head != nil {
+					// avoid force push from remote
+					if err = wd.Reset(&git.ResetOptions{
+						Commit: head.Hash(),
+						Mode:   git.HardReset,
+					}); err != nil {
+						err = fmt.Errorf("unable to reset to '%s'", head.Hash().String())
+						return
+					}
+				}
+
 				if err = wd.Checkout(&git.CheckoutOptions{
-					Branch: plumbing.NewBranchReferenceName(branch),
+					Branch: plumbing.NewRemoteReferenceName(remoteName, branch),
 					Create: false,
-					Force:  true,
+					Keep:   true,
 				}); err != nil {
 					err = fmt.Errorf("unable to checkout git branch: %s, error: %v", branch, err)
 					return
@@ -101,6 +112,8 @@ func FetchLatestRepo(provider string, branch string, progress io.Writer) (err er
 			err = fmt.Errorf("failed to open git local repository, error: %v", err)
 		}
 	} else {
+		_, _ = fmt.Fprintf(progress, "no local config exist, try to clone it\n")
+
 		if _, err = git.PlainClone(configDir, false, &git.CloneOptions{
 			RemoteName: remoteName,
 			URL:        repoAddr,