chore: move go fake runtime to a library (#389)

Co-authored-by: rick <[email protected]>

Author: LinuxSuRen

Makefile

@@ -10,9 +10,9 @@ build-linux-no-check:
 	CGO_ENABLE=0 GOOS=linux go build -ldflags "-w -s" -o bin/linux/hd
 	upx bin/linux/hd
 
-test: fmt lint
+test: fmt
 	go test ./... -coverprofile coverage.out
-pre-commit: fmt lint test build
+pre-commit: fmt test build
 cp-pre-commit:
 	cp .github/pre-commit .git/hooks/pre-commit
 run:

cmd/get.go

@@ -19,10 +19,10 @@ import (
 	"github.com/linuxsuren/http-downloader/pkg/log"
 
 	"github.com/AlecAivazis/survey/v2"
-	"github.com/linuxsuren/http-downloader/pkg/exec"
 	"golang.org/x/net/html"
 	"golang.org/x/net/html/charset"
 
+	fakeruntime "github.com/linuxsuren/go-fake-runtime"
 	"github.com/linuxsuren/http-downloader/pkg"
 	"github.com/linuxsuren/http-downloader/pkg/installer"
 	"github.com/linuxsuren/http-downloader/pkg/net"
@@ -82,7 +82,7 @@ func newDownloadOption(ctx context.Context) *downloadOption {
 		RoundTripper: getRoundTripper(ctx),
 		fetcher:      &installer.DefaultFetcher{},
 		wait:         &sync.WaitGroup{},
-		execer:       exec.DefaultExecer{},
+		execer:       fakeruntime.DefaultExecer{},
 	}
 }
 
@@ -125,7 +125,7 @@ type downloadOption struct {
 	org           string
 	repo          string
 	fetcher       installer.Fetcher
-	execer        exec.Execer
+	execer        fakeruntime.Execer
 	ExpectVersion string // should be like >v1.1.0
 }
 
@@ -360,7 +360,7 @@ func (o *downloadOption) runE(cmd *cobra.Command, args []string) (err error) {
 	return
 }
 
-func downloadMagnetFile(proxyGitHub, target string, execer exec.Execer) (err error) {
+func downloadMagnetFile(proxyGitHub, target string, execer fakeruntime.Execer) (err error) {
 	targetCmd := "gotorrent"
 	is := installer.Installer{
 		Provider:    "github",

cmd/get_test.go

@@ -15,8 +15,8 @@ import (
 
 	"github.com/golang/mock/gomock"
 	"github.com/h2non/gock"
+	fakeruntime "github.com/linuxsuren/go-fake-runtime"
 	"github.com/linuxsuren/http-downloader/mock/mhttp"
-	"github.com/linuxsuren/http-downloader/pkg/exec"
 	"github.com/linuxsuren/http-downloader/pkg/installer"
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/assert"
@@ -226,18 +226,18 @@ func TestDownloadMagnetFile(t *testing.T) {
 		proxyGitHub string
 		target      string
 		prepare     func()
-		execer      exec.Execer
+		execer      fakeruntime.Execer
 		expectErr   bool
 	}{{
 		name:        "proxyGitHub and target is empty",
 		proxyGitHub: "",
 		target:      "",
-		execer:      exec.FakeExecer{},
+		execer:      fakeruntime.FakeExecer{},
 	}, {
 		name:        "failed to download",
 		proxyGitHub: "",
 		target:      "fake",
-		execer:      exec.FakeExecer{ExpectError: errors.New("error")},
+		execer:      fakeruntime.FakeExecer{ExpectError: errors.New("error")},
 		expectErr:   true,
 	}, {
 		name:        "one target item",
@@ -249,7 +249,7 @@ func TestDownloadMagnetFile(t *testing.T) {
 				Reply(http.StatusOK).
 				File("testdata/magnet.html")
 		},
-		execer:    exec.FakeExecer{},
+		execer:    fakeruntime.FakeExecer{},
 		expectErr: false,
 	}, {
 		name:        "HTTP server error response",
@@ -260,7 +260,7 @@ func TestDownloadMagnetFile(t *testing.T) {
 				Get("/").
 				ReplyError(errors.New("error"))
 		},
-		execer:    exec.FakeExecer{},
+		execer:    fakeruntime.FakeExecer{},
 		expectErr: true,
 	}}
 	for _, tt := range tests {

cmd/install.go

@@ -9,8 +9,8 @@ import (
 	"strings"
 
 	"github.com/AlecAivazis/survey/v2"
+	fakeruntime "github.com/linuxsuren/go-fake-runtime"
 	"github.com/linuxsuren/http-downloader/pkg/common"
-	"github.com/linuxsuren/http-downloader/pkg/exec"
 	"github.com/linuxsuren/http-downloader/pkg/installer"
 	"github.com/linuxsuren/http-downloader/pkg/os"
 	"github.com/linuxsuren/http-downloader/pkg/version"
@@ -22,7 +22,7 @@ import (
 func newInstallCmd(ctx context.Context) (cmd *cobra.Command) {
 	opt := &installOption{
 		downloadOption: newDownloadOption(ctx),
-		execer:         &exec.DefaultExecer{},
+		execer:         &fakeruntime.DefaultExecer{},
 	}
 	cmd = &cobra.Command{
 		Use:     "install",
@@ -88,7 +88,7 @@ type installOption struct {
 	// inner fields
 	nativePackage bool
 	tool          string
-	execer        exec.Execer
+	execer        fakeruntime.Execer
 }
 
 func (o *installOption) shouldInstall() (should, exist bool) {

cmd/install_test.go

@@ -7,7 +7,7 @@ import (
 	"testing"
 
 	cotesting "github.com/linuxsuren/cobra-extension/pkg/testing"
-	"github.com/linuxsuren/http-downloader/pkg/exec"
+	fakeruntime "github.com/linuxsuren/go-fake-runtime"
 	"github.com/linuxsuren/http-downloader/pkg/installer"
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/assert"
@@ -118,7 +118,7 @@ func TestInstallPreRunE(t *testing.T) {
 func TestShouldInstall(t *testing.T) {
 	opt := &installOption{
 		downloadOption: &downloadOption{},
-		execer: &exec.FakeExecer{
+		execer: &fakeruntime.FakeExecer{
 			ExpectOutput: "v1.2.3",
 		},
 		tool: "fake",
@@ -129,7 +129,7 @@ func TestShouldInstall(t *testing.T) {
 
 	{
 		optGreater := &installOption{
-			execer: &exec.FakeExecer{
+			execer: &fakeruntime.FakeExecer{
 				ExpectOutput: "v1.2.3",
 			},
 			downloadOption: &downloadOption{
@@ -152,7 +152,7 @@ func TestShouldInstall(t *testing.T) {
 	assert.True(t, exist)
 
 	// not exist
-	opt.execer = &exec.FakeExecer{
+	opt.execer = &fakeruntime.FakeExecer{
 		ExpectError:         errors.New("fake"),
 		ExpectLookPathError: errors.New("error"),
 	}
@@ -176,7 +176,7 @@ func TestInstall(t *testing.T) {
 		opt: &installOption{
 			downloadOption: &downloadOption{},
 			nativePackage:  true,
-			execer:         exec.FakeExecer{},
+			execer:         fakeruntime.FakeExecer{},
 		},
 		args:      args{cmd: &cobra.Command{}},
 		expectErr: false,
@@ -195,29 +195,29 @@ func TestInstall(t *testing.T) {
 func TestGetDefaultInstallDir(t *testing.T) {
 	tests := []struct {
 		name   string
-		execer exec.Execer
+		execer fakeruntime.Execer
 		expect string
 	}{{
 		name: "linux",
-		execer: exec.FakeExecer{
+		execer: fakeruntime.FakeExecer{
 			ExpectOS: "linux",
 		},
 		expect: "/usr/local/bin",
 	}, {
 		name: "darwin",
-		execer: exec.FakeExecer{
+		execer: fakeruntime.FakeExecer{
 			ExpectOS: "darwin",
 		},
 		expect: "/usr/local/bin",
 	}, {
 		name: "windows",
-		execer: exec.FakeExecer{
+		execer: fakeruntime.FakeExecer{
 			ExpectOS: "windows",
 		},
 		expect: `C:\Program Files (x86)\Common Files`,
 	}, {
 		name:   "unknown",
-		execer: exec.FakeExecer{},
+		execer: fakeruntime.FakeExecer{},
 		expect: "",
 	}}
 	for _, tt := range tests {

go.mod

@@ -16,7 +16,7 @@ require (
 	github.com/spf13/cobra v1.6.1
 	github.com/spf13/pflag v1.0.5
 	github.com/spf13/viper v1.9.0
-	github.com/stretchr/testify v1.8.1
+	github.com/stretchr/testify v1.8.2
 	github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8
 	gopkg.in/yaml.v3 v3.0.1
 )
@@ -25,13 +25,13 @@ require (
 	github.com/antonmedv/expr v1.11.1
 	github.com/creack/pty v1.1.17
 	github.com/k0kubun/go-ansi v0.0.0-20180517002512-3bf9e2903213
+	github.com/linuxsuren/go-fake-runtime v0.0.0-20230426144714-1a7a0d160d3f
 	github.com/schollz/progressbar/v3 v3.13.0
 )
 
 require (
 	github.com/mattn/go-runewidth v0.0.14 // indirect
 	github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db // indirect
-	github.com/prometheus/client_golang v1.11.1 // indirect
 	github.com/rivo/uniseg v0.4.3 // indirect
 )