Installing on new server has a conflict because I already am creating a sudoers.d file for the nagios user.

[withanhdammit]

This issue respects the following points:

• This is a bug, not a question or a setup/configuration issue.
• This issue is not already reported on Github (I've searched it).
• I use the latest release of the Monitoring Plugins (https://github.com/Linuxfabrik/monitoring-plugins/releases).
• I agree to follow Monitoring Plugins's Code of Conduct.

Which variant of the Monitoring Plugins do you use?

• .rpm/.deb package from repo.linuxfabrik.ch
• Compiled for Linux from download.linuxfabrik.ch
• Compiled for Windows from download.linuxfabrik.ch
• Source Code from GitHub

Bug description

I just installed a new Debian server and it's throwing a sudoers.d conflict/error after installing the plugins because my install script already adds a sudoers.d file for 'nagios'. I've been doing that for years before I found your plugin set, so the nagios user can run the check commands.

Steps to reproduce - Plugin call

apt install linuxfabrik-monitoring-plugins

Steps to reproduce - Data

Selecting previously unselected package linuxfabrik-monitoring-plugins.
(Reading database ... 50103 files and directories currently installed.)
Preparing to unpack .../linuxfabrik-monitoring-plugins_1.2.0.11-1_amd64.deb ...
Unpacking linuxfabrik-monitoring-plugins (1.2.0.11-1) ...
Setting up linuxfabrik-monitoring-plugins (1.2.0.11-1) ...
/etc/sudoers.d/nagios:3:1643: Alias "NAGIOS" already defined
Cmnd_Alias NAGIOS = /usr/lib64/nagios/plugins/about-me, /usr/lib64/nagios/plugins/borgbackup, /usr/lib64/nagios/plugins/dhcp-relayed, /usr/lib64/nagios/plugins/disk-smart, /usr/lib64/nagios/plugins/disk-usage, /usr/lib64/nagios/plugins/dmesg, /usr/lib64/nagios/plugins/docker-info, /usr/lib64/nagios/plugins/docker-stats, /usr/lib64/nagios/plugins/fail2ban, /usr/lib64/nagios/plugins/file-age, /usr/lib64/nagios/plugins/file-size, /usr/lib64/nagios/plugins/ipmi-sel, /usr/lib64/nagios/plugins/ipmi-sensor, /usr/lib64/nagios/plugins/journald-query, /usr/lib64/nagios/plugins/journald-usage, /usr/lib64/nagios/plugins/kvm-vm, /usr/lib64/nagios/plugins/logfile, /usr/lib64/nagios/plugins/mysql-logfile, /usr/lib64/nagios/plugins/needs-restarting, /usr/lib64/nagios/plugins/network-bonding, /usr/lib64/nagios/plugins/nextcloud-version, /usr/lib64/nagios/plugins/openvpn-client-list, /usr/lib64/nagios/plugins/path-rw-test, /usr/lib64/nagios/plugins/php-status, /usr/lib64/nagios/plugins/restic-check, /usr/lib64/nagios/plugins/restic-snapshots, /usr/lib64/nagios/plugins/restic-stats, /usr/lib64/nagios/plugins/strongswan-connections

Environment

n/a

Plugin Version

linuxfabrik-monitoring-plugins_1.2.0.11-1_amd64.deb

Python version

No response

List of Python modules

No response

Additional Information

No response

[withanhdammit]

I ended up taking out the creation of the /etc/sudoers.d/nagios from my Icinga installer script and that resolved the issue, however it would be nice if the package checked to see if nagios already has sudo/nopasswd authority and if so, to not add a potentially duplicate sudoers.d file.

[markuslf]

@ma-benedetti Would be nice if the next rpm package could check sudo --list --other-user=icinga --non-interactive 2>&1 | grep 'NOPASSWD' (deb package: sudo --list --other-user=nagios --non-interactive 2>&1 | grep 'NOPASSWD') before dropping our sudoers file.

[markuslf]

We simply prefix the Cmnd_Alias with lf_ in the next version.