Fixed issue #155 on iOS

Eric Lange · Eric Lange · commit 4b8d6cddbad8 · 2020-03-22T12:01:49.000+01:00
Object.setPrototypeOf should return the set prototype, not `true` on success per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/setPrototypeOf
diff --git a/LiquidCore/src/ios/V82JSC/Context.cpp b/LiquidCore/src/ios/V82JSC/Context.cpp
@@ -412,9 +412,9 @@ Local<v8::Context> v8::Context::New(Isolate* isolate, ExtensionConfiguration* ex
                 }
 
                 if (SetPrototypeSkipHidden(info.GetIsolate()->GetCurrentContext(), obj, proto)) {
-                    info.GetReturnValue().Set(True(info.GetIsolate()));
+                    info.GetReturnValue().Set(proto);
                 } else {
-                    info.GetReturnValue().Set(False(info.GetIsolate()));
+                    info.GetReturnValue().Set(Null(info.GetIsolate()));
                 }
             });
         Local<FunctionTemplate> getPrototypeOf = FunctionTemplate::New(

Original file line number	Diff line number	Diff line change
`@@ -412,9 +412,9 @@ Local<v8::Context> v8::Context::New(Isolate* isolate, ExtensionConfiguration* ex`
`412`	`412`	`}`
`413`	`413`
`414`	`414`	`if (SetPrototypeSkipHidden(info.GetIsolate()->GetCurrentContext(), obj, proto)) {`
`415`		`- info.GetReturnValue().Set(True(info.GetIsolate()));`
	`415`	`+ info.GetReturnValue().Set(proto);`
`416`	`416`	`} else {`
`417`		`- info.GetReturnValue().Set(False(info.GetIsolate()));`
	`417`	`+ info.GetReturnValue().Set(Null(info.GetIsolate()));`
`418`	`418`	`}`
`419`	`419`	`});`
`420`	`420`	`Local<FunctionTemplate> getPrototypeOf = FunctionTemplate::New(`