refactor: refactoring debug command with new command api

Author: ShrBox

src/legacy/main/BuiltinCommands.cpp

@@ -6,6 +6,9 @@
 #include "ll/api/service/Bedrock.h"
 #include "lse/Entry.h"
 #include "mc/server/commands/CommandPermissionLevel.h"
+#include "ll/api/command/Command.h"
+#include "ll/api/command/CommandHandle.h"
+#include "ll/api/command/CommandRegistrar.h"
 
 #include <string>
 
@@ -42,37 +45,71 @@ bool ProcessDebugEngine(const std::string& cmd) {
     return true;
 }
 
+struct EngineDebugCommand {
+    std::string eval;
+};
+
 void RegisterDebugCommand() {
-    auto command =
-        DynamicCommand::createCommand(LLSE_DEBUG_CMD, "Debug LegacyScriptEngine", CommandPermissionLevel::Owner);
-    command->optional("eval", DynamicCommand::ParameterType::RawText);
-    command->addOverload("eval");
-    command->setCallback([](DynamicCommand const&,
-                            CommandOrigin const&,
-                            CommandOutput&,
-                            std::unordered_map<std::string, DynamicCommand::Result>& results) {
-        if (results["eval"].isSet) {
-            EngineScope enter(debugEngine);
-            try {
-                auto               result = debugEngine->eval(results["eval"].getRaw<std::string>());
-                std::ostringstream sout;
-                PrintValue(sout, result);
-                lse::getSelfPluginInstance().getLogger().info(sout.str());
-            } catch (Exception& e) {
-                PrintException(e);
-            }
-        } else {
-            if (isInConsoleDebugMode) {
-                // EndDebug
-                lse::getSelfPluginInstance().getLogger().info("Debug mode ended");
-                isInConsoleDebugMode = false;
+    // Old dynamic command, just for testing
+
+    //    auto command =
+    //        DynamicCommand::createCommand(LLSE_DEBUG_CMD, "Debug LegacyScriptEngine", CommandPermissionLevel::Owner);
+    //    command->optional("eval", DynamicCommand::ParameterType::RawText);
+    //    command->addOverload("eval");
+    //    command->setCallback([](DynamicCommand const&,
+    //                            CommandOrigin const&,
+    //                            CommandOutput&                                           output,
+    //                            std::unordered_map<std::string, DynamicCommand::Result>& results) {
+    //        if (results["eval"].isSet) {
+    //            EngineScope enter(debugEngine);
+    //            try {
+    //                auto               result = debugEngine->eval(results["eval"].getRaw<std::string>());
+    //                std::ostringstream sout;
+    //                PrintValue(sout, result);
+    //                output.success(sout.str());
+    //            } catch (Exception& e) {
+    //                PrintException(e);
+    //            }
+    //        } else {
+    //            if (isInConsoleDebugMode) {
+    //                // EndDebug
+    //                lse::getSelfPluginInstance().getLogger().info("Debug mode ended");
+    //                isInConsoleDebugMode = false;
+    //            } else {
+    //                // StartDebug
+    //                lse::getSelfPluginInstance().getLogger().info("Debug mode begins");
+    //                isInConsoleDebugMode = true;
+    //                std::cout << "> " << std::flush;
+    //            }
+    //        }
+    //    });
+    //    DynamicCommand::setup(ll::service::getCommandRegistry(), std::move(command));
+    auto& command = ll::command::CommandRegistrar::getInstance()
+                        .getOrCreateCommand(LLSE_DEBUG_CMD, "Debug LegacyScriptEngine", CommandPermissionLevel::Owner);
+    command.overload<EngineDebugCommand>().optional("eval").execute(
+        [](CommandOrigin const&, CommandOutput& output, EngineDebugCommand const& param) {
+            if (!param.eval.empty()) {
+                EngineScope enter(debugEngine);
+                try {
+                    auto               result = debugEngine->eval(param.eval);
+                    std::ostringstream sout;
+                    PrintValue(sout, result);
+                    output.success(sout.str());
+                } catch (Exception& e) {
+                    PrintException(e);
+                }
             } else {
-                // StartDebug
-                lse::getSelfPluginInstance().getLogger().info("Debug mode begins");
-                isInConsoleDebugMode = true;
-                std::cout << "> " << std::flush;
+                if (isInConsoleDebugMode) {
+                    // EndDebug
+                    lse::getSelfPluginInstance().getLogger().info("Debug mode ended");
+                    isInConsoleDebugMode = false;
+                } else {
+                    // StartDebug
+                    lse::getSelfPluginInstance().getLogger().info("Debug mode begins");
+                    isInConsoleDebugMode = true;
+                    std::cout << "> " << std::flush;
+                }
             }
         }
-    });
-    DynamicCommand::setup(ll::service::getCommandRegistry(), std::move(command));
+    );
 }