fix: fix npm command

Author: xiaoqch

docs/apis/LanguageSupport.md

@@ -64,7 +64,7 @@ Currently, LSE supports writing plugins in the following languages：
 - Distribute the **.llplugin** file as a plugin. When installing the plugin, just place this file directly into the
   plugins directory
 - LSE will automatically recognize the **.llplugin** file when BDS launch, extract it to the
-  `plugins/nodejs/<PluginName>` directory, and automatically execute `npm install` in the directory to install the
+  `plugins/nodejs/<PluginName>` directory, and automatically execute `npm install --omit=dev` in the directory to install the
   dependency packages. No manual intervention is needed for the whole process
 
 ## Python language support description

docs/apis/LanguageSupport.zh.md

@@ -48,7 +48,7 @@
 - 在插件编写完成之后，请将 `package.json` 以及所有插件源码打包为一个zip压缩包，并**将文件名后缀修改为 .llplugin**
 - `node_modules` 目录请勿打包在压缩包之中
 - 将 **.llplugin** 文件作为插件分发，安装插件时直接将此文件放置到 plugins 目录即可
-- 在开服时，脚本引擎会自动识别 **.llplugin** 文件，将其解压到`plugins/nodejs/插件名`目录，并在目录中自动执行 `npm install`
+- 在开服时，脚本引擎会自动识别 **.llplugin** 文件，将其解压到`plugins/nodejs/插件名`目录，并在目录中自动执行 `npm install --omit=dev`
   安装依赖包，整个过程无需人工干预
 
 ## Python 语言支持说明

src/legacy/main/NodeJsHelper.cpp

@@ -1,6 +1,7 @@
-#include <filesystem>
 #pragma warning(disable : 4251)
 
+#include "main/NodeJsHelper.h"
+
 #include "api/EventAPI.h"
 #include "engine/EngineManager.h"
 #include "engine/EngineOwnData.h"
@@ -15,12 +16,10 @@
 #include "ll/api/thread/ServerThreadExecutor.h"
 #include "ll/api/utils/StringUtils.h"
 #include "main/Global.h"
-#include "main/NodeJsHelper.h"
+#include "utils/Utils.h"
 #include "uv/uv.h"
 #include "v8/v8.h"
 
-#include <functional>
-
 using ll::chrono_literals::operator""_tick;
 
 // pre-declare
@@ -41,24 +40,25 @@ std::vector<node::Environment*>              uvLoopTask;
 
 bool initNodeJs() {
     // Init NodeJs
-    WCHAR buf[MAX_PATH];
-    GetCurrentDirectory(MAX_PATH, buf);
-    auto  path  = ll::string_utils::wstr2str(buf) + "\\bedrock_server_mod.exe";
+    auto  path  = ll::string_utils::u8str2str(ll::sys_utils::getModulePath(nullptr).value().u8string());
     char* cPath = (char*)path.c_str();
     uv_setup_args(1, &cPath);
-    args        = {path};
-    auto result = node::InitializeOncePerProcess(
-        args,
+    auto full_args = std::vector<std::string>{path};
+    auto result    = node::InitializeOncePerProcess(
+        full_args,
         {node::ProcessInitializationFlags::kNoInitializeV8,
-         node::ProcessInitializationFlags::kNoInitializeNodeV8Platform}
+            node::ProcessInitializationFlags::kNoInitializeNodeV8Platform}
     );
-    exec_args = result->exec_args();
     if (result->exit_code() != 0) {
         lse::LegacyScriptEngine::getInstance().getSelf().getLogger().error(
             "Failed to initialize node! NodeJs plugins won't be loaded"
         );
+        for (const std::string& error : result->errors())
+            lse::LegacyScriptEngine::getInstance().getSelf().getLogger().error(error);
         return false;
     }
+    args      = result->args();
+    exec_args = result->exec_args();
 
     // Init V8
     using namespace v8;
@@ -382,8 +382,8 @@ bool isESModulesSystem(const std::string& dirPath) {
 
 bool processConsoleNpmCmd(const std::string& cmd) {
 #ifdef LEGACY_SCRIPT_ENGINE_BACKEND_NODEJS
-    if (cmd.starts_with("npm ")) {
-        executeNpmCommand(cmd);
+    if (cmd.starts_with("npm ") || cmd.starts_with("npx ")) {
+        executeNpmCommand(SplitCmdLine(cmd));
         return false;
     } else {
         return true;
@@ -393,21 +393,35 @@ bool processConsoleNpmCmd(const std::string& cmd) {
 #endif
 }
 
-int executeNpmCommand(const std::string& cmd, std::string workingDir) {
+int executeNpmCommand(std::vector<std::string> npmArgs, std::string workingDir) {
     if (!nodeJsInited && !initNodeJs()) {
         return -1;
     }
     std::string engineDir =
         ll::string_utils::u8str2str(lse::LegacyScriptEngine::getInstance().getSelf().getModDir().u8string());
     if (workingDir.empty()) workingDir = engineDir;
-    std::vector<std::string>                      errors;
+
+    auto npmPath = std::filesystem::absolute(engineDir) / "node_modules" / "npm" / "bin" / "npm-cli.js";
+    std::vector<std::string>& env_args = npmArgs;
+    if (!env_args.empty() && (env_args[0] == "npm" || env_args[0] == "npx")) {
+        if (env_args[0] == "npx") {
+            npmPath = std::filesystem::absolute(engineDir) / "node_modules" / "npm" / "bin" / "npx-cli.js";
+        }
+        env_args.erase(env_args.begin());
+    }
+    auto scriptPath = ll::string_utils::replaceAll(ll::string_utils::u8str2str(npmPath.u8string()), "\\", "/");
+    env_args.insert(env_args.begin(), {args[0], scriptPath});
+
+    std::vector<std::string> errors;
+
     std::unique_ptr<node::CommonEnvironmentSetup> setup = node::CommonEnvironmentSetup::Create(
         platform.get(),
         &errors,
-        args,
+        env_args,
         exec_args,
         node::EnvironmentFlags::kOwnsProcessState
     );
+
     // if kOwnsInspector set, inspector_agent.cc:681
     // CHECK_EQ(start_io_thread_async_initialized.exchange(true), false) fail!
 
@@ -437,26 +451,40 @@ int executeNpmCommand(const std::string& cmd, std::string workingDir) {
             R"(
                 const engineDir = "{0}";
                 const workingDir = "{1}";
-                const command = "{2}";
-                const oldCwd = process.cwd();
+                const scriptPath = "{2}";
                 const publicRequire = require("module").createRequire(
                     require("path").resolve(engineDir) + require("path").sep
                 );
+                // Record states and restore at exit
+                const oldCwd = process.cwd();
+                const oldEnv = Object.entries(process.env).filter(([k]) => k.startsWith("npm_"));
+                const oldTitle = process.title;
+                process.on("exit", () => {{
+                    Object.keys(process.env)
+                        .filter((k) => k.startsWith("npm_"))
+                        .forEach((k) => delete process.env[k]);
+                    oldEnv.forEach(([k, v]) => (process.env[k] = v));
+                    process.title = oldTitle;
+                    process.chdir(oldCwd);
+                }});
+
                 process.chdir(workingDir);
-                publicRequire("npm-js-interface")(command);
-                process.chdir(oldCwd);
+                publicRequire(scriptPath);
             )",
             engineDir,
             workingDir,
-            cmd
+            scriptPath
         );
 
         try {
-            node::SetProcessExitHandler(env, [&](node::Environment* env_, int exit_code) { node::Stop(env); });
+            node::SetProcessExitHandler(env, [&](node::Environment*, int exit_code_) {
+                exit_code = exit_code_;
+                node::Stop(env);
+            });
             MaybeLocal<v8::Value> loadenv_ret = node::LoadEnvironment(env, executeJs);
             if (loadenv_ret.IsEmpty()) // There has been a JS exception.
-                throw "error";
-            exit_code = node::SpinEventLoop(env).FromMaybe(0);
+                throw std::runtime_error("Failed at LoadEnvironment");
+            exit_code = node::SpinEventLoop(env).FromMaybe(exit_code);
         } catch (...) {
             lse::LegacyScriptEngine::getInstance().getSelf().getLogger().error(
                 "Fail to execute NPM command. Error occurs"

src/legacy/main/NodeJsHelper.h

@@ -30,6 +30,6 @@ bool        doesPluginPackHasDependency(const std::string& dirPath);
 bool        isESModulesSystem(const std::string& dirPath);
 
 bool processConsoleNpmCmd(const std::string& cmd);
-int  executeNpmCommand(const std::string& cmd, std::string workingDir = "");
+int executeNpmCommand(std::vector<std::string> npmArgs = {"i", "--omit=dev", "--no-fund"}, std::string workingDir = "");
 
 } // namespace NodeJsHelper

src/lse/PluginManager.cpp

@@ -116,7 +116,10 @@ ll::Expected<> PluginManager::load(ll::mod::Manifest manifest) {
                 fmt::arg("name", ll::string_utils::u8str2str(dirPath.filename().u8string()))
             )
         );
-        if ((exitCode = NodeJsHelper::executeNpmCommand("npm install", ll::string_utils::u8str2str(dirPath.u8string())))
+        if ((exitCode = NodeJsHelper::executeNpmCommand(
+                 {"install", "--omit=dev", "--no-fund"},
+                 ll::string_utils::u8str2str(dirPath.u8string())
+             ))
             != 0) {
             lse::LegacyScriptEngine::getInstance().getSelf().getLogger().error(
                 "Error occurred. Exit code: {code}"_tr(fmt::arg("code", exitCode))