fix: fix Player::setNbt

ShrBox · ShrBox · commit 36693a7b379c · 2024-08-05T00:25:14.000+08:00
diff --git a/src/legacy/api/PlayerAPI.cpp b/src/legacy/api/PlayerAPI.cpp
@@ -3000,9 +3000,9 @@ Local<Value> PlayerClass::getNbt(const Arguments& args) {
         Player* player = get();
         if (!player) return Local<Value>();
 
-        CompoundTag* tag = new CompoundTag();
+        std::unique_ptr<CompoundTag> tag = std::make_unique<CompoundTag>();
         player->save(*tag);
-        return NbtCompoundClass::pack(tag);
+        return NbtCompoundClass::pack(std::move(tag));
     }
     CATCH("Fail in getNbt!")
 }

Original file line number	Diff line number	Diff line change
`@@ -3000,9 +3000,9 @@ Local<Value> PlayerClass::getNbt(const Arguments& args) {`
`3000`	`3000`	`Player* player = get();`
`3001`	`3001`	`if (!player) return Local<Value>();`
`3002`	`3002`
`3003`		`- CompoundTag* tag = new CompoundTag();`
	`3003`	`+ std::unique_ptr<CompoundTag> tag = std::make_unique<CompoundTag>();`
`3004`	`3004`	`player->save(*tag);`
`3005`		`- return NbtCompoundClass::pack(tag);`
	`3005`	`+ return NbtCompoundClass::pack(std::move(tag));`
`3006`	`3006`	`}`
`3007`	`3007`	`CATCH("Fail in getNbt!")`
`3008`	`3008`	`}`