refactor: remove more macro

Author: ShrBox

src/legacy/api/RemoteCallAPI.cpp

@@ -21,7 +21,6 @@
 #include <string>
 
 #define DEFAULT_REMOTE_CALL_NAME_SPACE "LLSEGlobal"
-#define logger                         lse::getSelfPluginInstance().getLogger()
 
 //////////////////// Remote Call ////////////////////
 
@@ -180,8 +179,12 @@ Local<Value> extract(RemoteCall::ValueType&& val) {
 Local<Value> MakeRemoteCall(const string& nameSpace, const string& funcName, const Arguments& args) {
     auto& func = RemoteCall::importFunc(nameSpace, funcName);
     if (!func) {
-        logger.error("Fail to import! Function [{}::{}] has not been exported!", nameSpace, funcName);
-        logger.error("In plugin <{}>", getEngineOwnData()->pluginName);
+        lse::getSelfPluginInstance().getLogger().error(
+            "Fail to import! Function [{}::{}] has not been exported!",
+            nameSpace,
+            funcName
+        );
+        lse::getSelfPluginInstance().getLogger().error("In plugin <{}>", getEngineOwnData()->pluginName);
         return Local<Value>();
     }
 
@@ -211,7 +214,7 @@ bool LLSEExportFunc(
         try {
             auto iter = getEngineData(engine)->exportFuncs.find(identifier);
             if (iter == getEngineData(engine)->exportFuncs.end()) {
-                logger.debug("");
+                lse::getSelfPluginInstance().getLogger().debug("");
                 return "";
             }
             auto                              scriptCallback = iter->second.callback.get();

src/legacy/main/BuiltinCommands.cpp

@@ -16,8 +16,6 @@
 extern bool          isInConsoleDebugMode;
 extern ScriptEngine* debugEngine;
 
-#define OUTPUT_DEBUG_SIGN() std::cout << "> " << std::flush
-
 bool ProcessDebugEngine(const std::string& cmd) {
 #ifdef LEGACY_SCRIPT_ENGINE_BACKEND_PYTHON
     // process python debug seperately
@@ -33,11 +31,11 @@ bool ProcessDebugEngine(const std::string& cmd) {
                 std::ostringstream sout;
                 PrintValue(sout, result);
                 lse::getSelfPluginInstance().getLogger().info(sout.str());
-                OUTPUT_DEBUG_SIGN();
+                std::cout << "> " << std::flush;
             }
         } catch (Exception& e) {
             PrintException(e);
-            OUTPUT_DEBUG_SIGN();
+            std::cout << "> " << std::flush;
         }
         return false;
     }
@@ -72,7 +70,7 @@ void RegisterDebugCommand() {
                 // StartDebug
                 lse::getSelfPluginInstance().getLogger().info("Debug mode begins");
                 isInConsoleDebugMode = true;
-                OUTPUT_DEBUG_SIGN();
+                std::cout << "> " << std::flush;
             }
         }
     });