fix: plugin migration

Author: futrime

CHANGELOG.md

@@ -23,8 +23,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - First release.
 
-  [0.1.5]: https://github.com/LiteLDev/LegacyScriptEngine/compare/v0.1.4...v0.1.5
-
 [0.1.6]: https://github.com/LiteLDev/LegacyScriptEngine/compare/v0.1.5...v0.1.6
 [0.1.5]: https://github.com/LiteLDev/LegacyScriptEngine/compare/v0.1.4...v0.1.5
 [0.1.4]: https://github.com/LiteLDev/LegacyScriptEngine/releases/tag/v0.1.4

README.md

@@ -4,14 +4,6 @@ A plugin engine for running LLSE plugins on LeviLamina
 
 ## Install
 
-Before you install LegacyScriptEgnine, you need to install dependencies firstly:
-
-```sh
-lip install github.com/LiteLDev/LegacyMoney
-lip install github.com/LiteLDev/LegacyRemoteCall
-lip install github.com/LiteLDev/LegacyParticleAPI
-```
-
 To install all engines as a whole, you can use the following command:
 
 ```sh

docs/index.md

@@ -4,14 +4,6 @@ A plugin engine for running LLSE plugins on LeviLamina
 
 ## Install
 
-Before you install LegacyScriptEgnine, you need to install dependencies firstly:
-
-```sh
-lip install github.com/LiteLDev/LegacyMoney
-lip install github.com/LiteLDev/LegacyRemoteCall
-lip install github.com/LiteLDev/LegacyParticleAPI
-```
-
 To install all engines as a whole, you can use the following command:
 
 ```sh

docs/index.zh.md

@@ -4,14 +4,6 @@
 
 ## 安装
 
-在安装 LegacyScriptEngine 之前，您需要先安装依赖项：
-
-```sh
-lip install github.com/LiteLDev/LegacyMoney
-lip install github.com/LiteLDev/LegacyRemoteCall
-lip install github.com/LiteLDev/LegacyParticleAPI
-```
-
 要一次性安装所有引擎，您可以使用以下命令：
 
 ```sh

src/lse/PluginMigration.cpp

@@ -35,26 +35,28 @@ auto migratePlugin(const std::filesystem::path& path) -> void {
 
     const auto& pluginType = pluginManager.getType();
 
-    const auto& pluginName     = path.filename();
-    const auto& pluginBaseName = path.stem();
-    const auto& pluginDir      = ll::plugin::getPluginsRoot() / pluginBaseName;
+    const auto& pluginFileName     = path.filename();
+    const auto& pluginFileBaseName = path.stem();
+    const auto& pluginDir          = ll::plugin::getPluginsRoot() / pluginFileBaseName;
 
-    if (std::filesystem::exists(pluginDir / path.filename())) {
+    if (std::filesystem::exists(pluginDir / pluginFileName)) {
         throw std::runtime_error(
             fmt::format("failed to migrate legacy plugin at {}: {} already exists", path.string(), pluginDir.string())
         );
     }
 
-    if (!std::filesystem::create_directory(pluginDir) && !std::filesystem::exists(pluginDir)) {
-        throw std::runtime_error(fmt::format("failed to create directory {}", pluginDir.string()));
+    if (!std::filesystem::exists(pluginDir)) {
+        if (!std::filesystem::create_directory(pluginDir)) {
+            throw std::runtime_error(fmt::format("failed to create directory {}", pluginDir.string()));
+        }
     }
 
     // Move plugin file.
-    std::filesystem::rename(path, pluginDir / pluginName);
+    std::filesystem::rename(path, pluginDir / pluginFileName);
 
     ll::plugin::Manifest manifest{
-        .entry = pluginName.string(),
-        .name  = pluginBaseName.string(),
+        .entry = pluginFileName.string(),
+        .name  = pluginFileBaseName.string(),
         .type  = pluginType,
         .dependencies =
             std::unordered_set<ll::plugin::Dependency>{