chore: disable onNpcCmd temporarily

Author: ShrBox

src/legacy/api/EventAPI.cpp

@@ -147,7 +147,6 @@ bool LLSECallEventsOnHotUnload(ScriptEngine* engine) {
 
 //////////////////// Events ////////////////////
 
-// TODO:
 void EnableEventListener(int eventId) {
     using namespace ll::event;
     EventBus& bus = EventBus::getInstance();

src/legacy/api/SimulatedPlayerAPI.cpp

@@ -145,7 +145,7 @@ Local<Value> PlayerClass::simulateDestroy(const Arguments& args) {
             CHECK_ARG_TYPE(args[index], ValueKind::kNumber);
             face = (ScriptModuleMinecraft::ScriptFacing)args[index].asNumber().toInt32();
         }
-        // TODO
+
         return Boolean::newBoolean(sp->simulateDestroyBlock(bpos, face));
     }
     CATCH("Fail in " __FUNCTION__ "!")

src/lse/events/EntityEvents.cpp

@@ -280,6 +280,7 @@ LL_TYPE_INSTANCE_HOOK(
     return origin(source, damage);
 }
 
+// TODO: fix this event, can't get correct vector via mUnke14f11
 LL_TYPE_INSTANCE_HOOK(
     NpcCommandHook,
     HookPriority::Normal,
@@ -292,10 +293,10 @@ LL_TYPE_INSTANCE_HOOK(
     ::std::string const& sceneName
 ) {
     IF_LISTENED(EVENT_TYPES::onNpcCmd) {
-        auto& actionContainer =
-            mActionsContainer->mUnke14f11.as<std::vector<std::variant<npc::CommandAction, npc::UrlAction>>>();
-        lse::LegacyScriptEngine::getInstance().getSelf().getLogger().info("Size: {}", actionContainer.size());
-        auto& action = actionContainer.at(actionIndex);
+        auto& action =
+            mActionsContainer->mUnke14f11.as<std::vector<std::variant<npc::CommandAction, npc::UrlAction>>>().at(
+                actionIndex
+            );
         if (std::holds_alternative<npc::CommandAction>(action)) {
             auto&       commands = std::get<npc::CommandAction>(action).commands;
             std::string command;
@@ -382,7 +383,9 @@ void MobHurtEvent() {
     MobHurtHook::hook();
     MobHurtEffectHook::hook();
 }
-void NpcCommandEvent() { NpcCommandHook::hook(); }
+void NpcCommandEvent() {
+    //    NpcCommandHook::hook();
+}
 void EffectUpdateEvent() { EffectUpdateHook::hook(); }
 void TransformationEvent() { TransformationHook::hook(); }
 } // namespace lse::events::entity