Skip to content

Commit fdc7447

Browse files
committed
fix: fix issue with preRelease in registerPlugin
1 parent 9dd1d6a commit fdc7447

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/legacy/api/LlAPI.cpp

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,12 @@ Local<Value> LlClass::getVersionStatus() {
135135
}
136136

137137
Local<Value> LlClass::registerPlugin(const Arguments& args) {
138-
CHECK_ARGS_COUNT(args, 1);
139-
CHECK_ARG_TYPE(args[0], ValueKind::kString);
138+
if (args.size() == 0) {
139+
return Boolean::newBoolean(true);
140+
} else {
141+
CHECK_ARG_TYPE(args[0], ValueKind::kString);
142+
}
140143
if (args.size() >= 2) CHECK_ARG_TYPE(args[1], ValueKind::kString);
141-
// if (args.size() >= 3)
142-
// CHECK_ARG_TYPE(args[2], ValueKind::kObject);
143144
if (args.size() >= 4) CHECK_ARG_TYPE(args[3], ValueKind::kObject);
144145

145146
try {
@@ -166,9 +167,11 @@ Local<Value> LlClass::registerPlugin(const Arguments& args) {
166167
if (status.isNumber()) {
167168
switch (status.asNumber().toInt32()) {
168169
case 0:
170+
ver.preRelease = ll::data::PreRelease();
169171
ver.preRelease->from_string("dev");
170172
break;
171173
case 1:
174+
ver.preRelease = ll::data::PreRelease();
172175
ver.preRelease->from_string("beta");
173176
break;
174177
default:
@@ -195,9 +198,11 @@ Local<Value> LlClass::registerPlugin(const Arguments& args) {
195198
if (status.isNumber()) {
196199
switch (status.asNumber().toInt32()) {
197200
case 0:
201+
ver.preRelease = ll::data::PreRelease();
198202
ver.preRelease->from_string("dev");
199203
break;
200204
case 1:
205+
ver.preRelease = ll::data::PreRelease();
201206
ver.preRelease->from_string("beta");
202207
break;
203208
default:

0 commit comments

Comments
 (0)