refactor: refactoring map find

Author: OEOTYAN

src/pl/SymbolProvider.cpp

@@ -151,7 +151,7 @@ void* pl_resolve_symbol(const char* symbolName) {
         Error("pl_resolve_symbol called before init");
         return nullptr;
     }
-    auto iter = funcMap->find(std::string(symbolName));
+    auto iter = funcMap->find(std::string_view(symbolName));
     if (iter == funcMap->end()) {
         Error("Could not find function in memory: {}", symbolName);
         Error("Plugin: {}", pl::utils::GetCallerModuleFileName());
@@ -162,7 +162,14 @@ void* pl_resolve_symbol(const char* symbolName) {
 
 void* pl_resolve_symbol_silent(const char* symbolName) {
     if (!funcMap) { return nullptr; }
-    auto iter = funcMap->find(std::string(symbolName));
+    auto iter = funcMap->find(std::string_view(symbolName));
+    if (iter == funcMap->end()) { return nullptr; }
+    return (void*)(imageBaseAddr + iter->second);
+}
+
+void* pl_resolve_symbol_silent_n(const char* symbolName, size_t size) {
+    if (!funcMap) { return nullptr; }
+    auto iter = funcMap->find(std::string_view(symbolName, size));
     if (iter == funcMap->end()) { return nullptr; }
     return (void*)(imageBaseAddr + iter->second);
 }

src/pl/SymbolProvider.h

@@ -32,6 +32,17 @@ PLCAPI void* pl_resolve_symbol(const char* symbolName);
  */
 PLCAPI void* pl_resolve_symbol_silent(const char* symbolName);
 
+/**
+ * @brief Resolve a symbol name to a function address.
+ *
+ * @param symbolName [in] The symbol name.
+ * @param symbolName [in] The name size.
+ * @return result The function address. nullptr if the function is not found.
+ *
+ * @note This function will not print error message if the function is not found.
+ */
+PLCAPI void* pl_resolve_symbol_silent_n(const char* symbolName, size_t size);
+
 /**
  * @brief Get the symbol name of a function address.
  *

src/pl/internal/StringUtils.cpp

@@ -12,23 +12,23 @@
 #include <winnls.h>
 
 std::wstring pl::utils::str2wstr(const std::string& str, UINT codePage) {
-    auto  len    = MultiByteToWideChar(codePage, 0, str.c_str(), -1, nullptr, 0);
-    auto* buffer = new wchar_t[len];
-    MultiByteToWideChar(codePage, 0, str.c_str(), -1, buffer, len);
-    std::wstring result = std::wstring(buffer);
-    delete[] buffer;
-    return result;
+    int          len = MultiByteToWideChar(codePage, 0, str.data(), (int)str.size(), nullptr, 0);
+    std::wstring wstr;
+    if (len == 0) { return wstr; }
+    wstr.reserve(len);
+    MultiByteToWideChar(codePage, 0, str.data(), (int)str.size(), wstr.data(), len);
+    return wstr;
 }
 
 std::wstring pl::utils::str2wstr(const std::string& str) { return str2wstr(str, CP_UTF8); }
 
 std::string pl::utils::wstr2str(const std::wstring& wstr) {
-    auto  len    = WideCharToMultiByte(CP_UTF8, 0, wstr.c_str(), -1, nullptr, 0, nullptr, nullptr);
-    char* buffer = new char[len];
-    WideCharToMultiByte(CP_UTF8, 0, wstr.c_str(), -1, buffer, len, nullptr, nullptr);
-    std::string result = std::string(buffer);
-    delete[] buffer;
-    return result;
+    int         len = WideCharToMultiByte(CP_UTF8, 0, wstr.data(), (int)wstr.size(), nullptr, 0, nullptr, nullptr);
+    std::string ret;
+    if (len == 0) { return ret; }
+    ret.reserve(len);
+    WideCharToMultiByte(CP_UTF8, 0, wstr.data(), (int)wstr.size(), ret.data(), (int)ret.size(), nullptr, nullptr);
+    return ret;
 }
 
 std::vector<std::string_view> pl::utils::split(std::string_view s, std::string_view delimiter) {

xmake.lua

@@ -18,10 +18,11 @@ add_requires("demangler ~17")
 target("PreLoader")
     set_kind("shared")
     set_languages("c++20")
-    set_symbols("debug")
+    set_symbols("debug")   
+     set_exceptions("none")
     add_headerfiles("src/(**.h)")
     add_includedirs("./src")
     add_defines("PRELOADER_EXPORT", "UNICODE")
-    add_cxflags("/utf-8")
+    add_cxflags("/utf-8", "/EHa")
     add_files("src/**.cpp")
     add_packages("raw_pdb", "nlohmann_json", "parallel-hashmap", "demangler", "detours", "fmt", "pe_bliss")